Skip to content

Update eslint to latest release, fix eslint fails, update CI to work in branches #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

chrissimpkins
Copy link
Contributor

No description provided.

@chrissimpkins chrissimpkins changed the title Update eslint to latest release, fix eslint fails Update eslint to latest release, fix eslint fails, update CI to work in branches Jan 28, 2025
@chrissimpkins chrissimpkins force-pushed the dep-updates-lint-fixes branch from bd97bf5 to db363d1 Compare January 28, 2025 16:10
@chrissimpkins
Copy link
Contributor Author

chrissimpkins commented Jan 28, 2025

From Harry Dalton (@Hoolean):

I just had a poke around, and I think it is indeed the profile format change from 0.12.0 that is tripping it up

A few import locations get shuffled too

Alternatively the CI script could invoke fontbakery check-googlefonts without a custom profile, although the custom profile probably has more interesting coverage, so I think I like the approach you are using now better : )

@chrissimpkins
Copy link
Contributor Author

chrissimpkins commented Jan 28, 2025

Alternatively the CI script could invoke fontbakery check-googlefonts without a custom profile,

IIRC I designed the CI checks so that they pass fontbakery checks because the CI fails if they don't. I'll need to dive back into the test implementations to see what we can do. Also, I want it to run reasonably fast. It's only meant to confirm that the fontbakery executable installation and configuration options supported in the Action here function correctly.

@chrissimpkins
Copy link
Contributor Author

The CI tests on the Action need to be updated to support the latest FB configuration. @felipesanches can you suggest how we fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant