fix(onboarding): hard-navigate to /dashboard after finish#86
Merged
Conversation
router.replace + router.refresh occasionally raced against the app layout's hasCompletedOnboarding check — the audit_log row insert hadn't been observed by the new request yet, so the layout bounced the user straight back to /onboarding with no visible feedback. Use window.location.href for a hard reload after the action resolves. Slower (~50ms) but deterministic. Also surfaces thrown errors in the toast instead of silently returning. Side-effects: - Drop unused useRouter import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
router.replace + router.refresh raced against the app layout's hasCompletedOnboarding check. The audit_log INSERT hadn't propagated to the new request yet → bounced back to /onboarding silently.
Use window.location.href for a hard reload. Slower (~50ms) but deterministic. Catch + surface thrown errors in the toast.