perf(server): #88 bulk DB loops + React.cache#91
Merged
Conversation
Closes #88. - affiliate.topReferrers: replace per-row SELECT with single inArray + Map lookup; also drops the buggy stub 'satisfy and() arity' query that was always one-row and discarded - gdpr.purgeExpiredDeletions: parallelize the markPurgedAt + audit insert per row, and reorder so we mark+audit BEFORE the user delete (previously the cascade wiped accountDeletion before the update, making the purgedAt write a silent no-op) - referral.recordAcceptance: Promise.all the update + audit per row, iterations themselves via Promise.allSettled - webhooks.processPendingDeliveries: parallelize the two status updates per delivery (delivery row + subscription row) - onboarding.hasCompletedOnboarding: wrap in React.cache so the layout + page no longer double-query per request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88. inArray bulk fetch, Promise.all in 4 hot loops, React.cache on hasCompletedOnboarding. Also fixes a latent bug in GDPR purge where the cascade wiped the row before the purgedAt update committed.