chore: restore clean biome baseline#108
Merged
Merged
Conversation
biome check had 6 errors on master (CI never gated on it, so the baseline drifted). Fix the two real source issues and stop linting vendored/generated trees: - admin/proxy.ts: build WEB_SIGN_IN with a template literal, and only take the APP_URL branch when it is set. Previously `undefined + "/sign-in"` produced a truthy "undefined/sign-in", so the localhost fallback never fired. - seo/json-ld.tsx: drop the unused noDangerouslySetInnerHtml suppression. - biome.json: ignore .agents (vendored skills), drizzle migrations/meta, and skills-lock.json, matching the existing .claude/.ruflo ignores. biome check now exits clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
biome check .had 6 errors on master. Biome is not a CI gate (no biome step in.github/workflows), so the lint baseline silently drifted while PRs stayed green.Changes
WEB_SIGN_INwith a template literal, and only use theNEXT_PUBLIC_APP_URLbranch when it's actually set. Latent bug: when unset,undefined + "/sign-in"evaluated to the truthy string"undefined/sign-in", so thelocalhost:3001fallback could never fire.noDangerouslySetInnerHtmlsuppression..agents(vendored skills),**/migrations/meta(drizzle-generated), andskills-lock.json, matching the existing.claude/.rufloignores.Result
pnpm exec biome check .exits 0 (warnings/infos only). Typecheck still green.Follow-ups (not in this PR)
biome checkas a CI gate so the baseline can't drift again (touches.github/workflows, flagged for human review).🤖 Generated with Claude Code