Skip to content

Conversation

@atjn
Copy link
Contributor

@atjn atjn commented Dec 10, 2024

Tabindexes change the expected flow of the page to make it less intuitive, we should get rid of them.

Partially ununfixes #494

Copy link
Member

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I partly disagree. Every other page than the frontpage should have tabindexes removed.

But I think the frontpage should be in this order: Quickbuy -> buy -> restart -> menu -> tilmeld. I feel like it's more intuitive for them to be in that order🤔 Even though it isn't standard web. My main argument for us to ignore the web in this sense, is the way it's accessed (through the stregkiosk) it doesn't feel like a webpage, it's closer to a kind of game.

@atjn
Copy link
Contributor Author

atjn commented Dec 10, 2024

I feel like it's more intuitive for them to be in that order🤔

The first time I used the stregsystem, I wanted to access the menu, so I pressed Shift + Tab because that moves you back up towards the header in almost all apps, but the stregsystem did something else which confused me, so now I just always use the mouse.

@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.80%. Comparing base (a02bfdb) to head (104d49e).
⚠️ Report is 23 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #540   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files          40       40           
  Lines        3809     3809           
  Branches      481      481           
=======================================
  Hits         3078     3078           
  Misses        675      675           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@krestenlaust
Copy link
Member

Should we maybe make a kind of design guideline? To point to, with discussions like these 🤔

@atjn
Copy link
Contributor Author

atjn commented Jan 12, 2025

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants