Hotfix: Product notes #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shout out to atjn for figuring out the fix.
krestenlaust
approved these changes
Feb 20, 2025
Member
krestenlaust
left a comment
krestenlaust
left a comment
There was a problem hiding this comment.
Awesome that you've added a test as well. Have you tested that it fails without the fix?
I'm hoping that @atjn can review it this time😅
Contributor
Author
Yes, I tested that it gives an error in tests when the fix is not applied. |
Member
|
Looking at it now, the namedtuples are a bit messy, might redo later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed that problem notes stopped products from showing up. The fix was found by @atjn.
Added test that makes it so we catch it the next time.