Conversation
f-lab-namu
reviewed
Dec 15, 2025
| @HealthCheck() | ||
| check() { | ||
| return this.health.check([ | ||
| () => this.http.pingCheck('server-check', 'http://localhost:3000/ping'), |
There was a problem hiding this comment.
http://localhost:3000/ping 이 부분은 환경별로 달라져야 할 것 같아요. static string 으로 code 에 넣는 것 보다 env 나 config 를 활용해서 따로 빼는게 좋겠어요.
|
f-lab-namu
reviewed
Dec 26, 2025
| ); | ||
| this.healthCheckUrl = this.configService.get<string>( | ||
| 'HEALTH_CHECK_URL', | ||
| 'http://localhost:3000/ping', |
There was a problem hiding this comment.
이 부분의 경우 로컬, 개발, 운영 환경 별로 url 이 다를테니 설정값 주입 형태로 처리되면 좋을 것 같아요.
f-lab-namu
approved these changes
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경사항
@nestjs/terminus 모듈을 활용한 HTTP 헬스 체크 컨트롤러 구현
HttpHealthIndicator.pingCheck()를 사용한 자체 서버 상태 확인
순환 참조 문제 방지를 위한 /ping 전용 헬스 엔드포인트 추가