Skip to content

feat: Migrate to bzlmod - #194

Merged
f0rmiga merged 14 commits into
f0rmiga:mainfrom
blorente:blorente/migrate_to_bzlmod
Aug 21, 2025
Merged

feat: Migrate to bzlmod#194
f0rmiga merged 14 commits into
f0rmiga:mainfrom
blorente:blorente/migrate_to_bzlmod

Conversation

@blorente

@blorente blorente commented Aug 16, 2025

Copy link
Copy Markdown
Contributor

Migrate gcc-toolchain to a bzlmod package.

This change intentionally doesn't:

  • Update the documentation to reflect that bzlmod can be used now. This should be done when gcc-toolchain exists in the BCR.
  • Default to bzlmod in the .bazelrc file. Instead, it creates a configuration bzlmod that enables it. I think we should add bzlmod to the test matrix, but I'd like @f0rmiga 's guidance on whether to add it for all configurations, or just for some.

I'm happy to change any of the above.

Testing:

Tested by running bazel test --config=bzlmod //... on an x86_64 machine running pretty stock Ubuntu 22.04. All tests pass.

Also tested by cross-compiling a target to aarch64 in a project that sets --noenable_workspace.

@blorente
blorente force-pushed the blorente/migrate_to_bzlmod branch 4 times, most recently from dd8e833 to 4416351 Compare August 17, 2025 19:34
Comment thread rules_cc/defs.bzl
@blorente
blorente force-pushed the blorente/migrate_to_bzlmod branch 4 times, most recently from 4570fdc to 500aa47 Compare August 18, 2025 11:08
@blorente
blorente marked this pull request as ready for review August 18, 2025 11:08
@blorente
blorente force-pushed the blorente/migrate_to_bzlmod branch 3 times, most recently from dbee5b5 to 0532389 Compare August 18, 2025 13:40
Comment thread rules_cc/defs.bzl
Comment thread toolchain/defs.bzl
Comment thread toolchain/module_extensions.bzl Outdated
@blorente
blorente requested a review from f0rmiga August 19, 2025 15:50
Comment thread toolchain/defs.bzl Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
@f0rmiga

f0rmiga commented Aug 20, 2025

Copy link
Copy Markdown
Owner

For CI, we should do a matrix and run all pipelines with bzlmod and workspaces.

@blorente

blorente commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

For CI, we should do a matrix and run all pipelines with bzlmod and workspaces.

@f0rmiga Thanks for the clarification! CI changes made here: fd97819

@blorente
blorente requested a review from f0rmiga August 20, 2025 09:24
Comment thread .bazelrc Outdated
@blorente
blorente force-pushed the blorente/migrate_to_bzlmod branch from eee32e8 to 2e4364b Compare August 20, 2025 17:48
@blorente
blorente requested a review from f0rmiga August 20, 2025 17:49
Comment thread .github/workflows/configure_bazelrc.sh Outdated
@blorente
blorente force-pushed the blorente/migrate_to_bzlmod branch from 1a9a4da to 84ce418 Compare August 21, 2025 06:27
@f0rmiga
f0rmiga merged commit 0e2242b into f0rmiga:main Aug 21, 2025
24 checks passed
f0rmiga pushed a commit that referenced this pull request Sep 2, 2025
This was supposed to be added in #194, but I forgot to commit the file.
Apologies!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants