feat: Migrate to bzlmod - #194
Merged
Merged
Conversation
blorente
force-pushed
the
blorente/migrate_to_bzlmod
branch
4 times, most recently
from
August 17, 2025 19:34
dd8e833 to
4416351
Compare
blorente
commented
Aug 17, 2025
blorente
force-pushed
the
blorente/migrate_to_bzlmod
branch
4 times, most recently
from
August 18, 2025 11:08
4570fdc to
500aa47
Compare
blorente
marked this pull request as ready for review
August 18, 2025 11:08
blorente
force-pushed
the
blorente/migrate_to_bzlmod
branch
3 times, most recently
from
August 18, 2025 13:40
dbee5b5 to
0532389
Compare
f0rmiga
reviewed
Aug 19, 2025
f0rmiga
reviewed
Aug 20, 2025
Owner
|
For CI, we should do a matrix and run all pipelines with bzlmod and workspaces. |
Contributor
Author
f0rmiga
reviewed
Aug 20, 2025
blorente
force-pushed
the
blorente/migrate_to_bzlmod
branch
from
August 20, 2025 17:48
eee32e8 to
2e4364b
Compare
blorente
commented
Aug 20, 2025
blorente
force-pushed
the
blorente/migrate_to_bzlmod
branch
from
August 21, 2025 06:27
1a9a4da to
84ce418
Compare
f0rmiga
approved these changes
Aug 21, 2025
f0rmiga
pushed a commit
that referenced
this pull request
Sep 2, 2025
This was supposed to be added in #194, but I forgot to commit the file. Apologies!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate gcc-toolchain to a bzlmod package.
This change intentionally doesn't:
.bazelrcfile. Instead, it creates a configurationbzlmodthat enables it. I think we should add bzlmod to the test matrix, but I'd like @f0rmiga 's guidance on whether to add it for all configurations, or just for some.I'm happy to change any of the above.
Testing:
Tested by running
bazel test --config=bzlmod //...on an x86_64 machine running pretty stock Ubuntu 22.04. All tests pass.Also tested by cross-compiling a target to aarch64 in a project that sets
--noenable_workspace.