Fix Option values displaying as Some("...") in log output#103
Conversation
… format Co-authored-by: f2calv <16097639+f2calv@users.noreply.github.com>
Some("...") in log output
There was a problem hiding this comment.
Pull request overview
Updates log formatting so Option values no longer render as Some("...") in Git/GitHub info logs (and in AppSettings’s Display output), improving readability of operational logs.
Changes:
- Switched affected log statements from
{:?}to{}and formattedOption<String>via.as_deref().unwrap_or("N/A"). - Formatted
Option<u64>/Option<u32>GitHub run fields into strings with anN/Afallback for missing values. - Updated
Displayimpl forAppSettingsto match the newOptionformatting behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
…/A literals Co-authored-by: f2calv <16097639+f2calv@users.noreply.github.com>
f2calv
left a comment
There was a problem hiding this comment.
The workflow is failing due to an external change in a GitHub Action, please fix, "The workflow is not valid. .github/workflows/ci.yml (Line: 47, Col: 11): Input image-registry is required, but not provided while calling. .github/workflows/ci.yml (Line: 47, Col: 11): Input image-repository is required, but not provided while calling."
f2calv
left a comment
There was a problem hiding this comment.
please also bump the latest cargo dependencies
…g changes Co-authored-by: f2calv <16097639+f2calv@users.noreply.github.com>
Fixed in commit
|
Co-authored-by: f2calv <16097639+f2calv@users.noreply.github.com>
Done in commit |
rustup toolchain install stable-<cross-target> attempts to install and run binaries for the target platform on the build host, which fails with "may not be able to run on this system". Cross-compilation only requires rustup target add <target> (stdlib for the target) plus the system cross-linker from apt. Removed the three rustup toolchain install lines. +semver:feature Co-authored-by: f2calv <16097639+f2calv@users.noreply.github.com>
…t flag error The latest chart-testing image no longer accepts --set via --helm-extra-set-args in ct install, causing "unknown flag: --set". Removing the input lets the reusable workflow default to ct lint which validates the chart without attempting a cluster install. Co-authored-by: f2calv <16097639+f2calv@users.noreply.github.com>
… devcontainer - GitVersion.yml: add copilot branch pattern to prevent >63-char helm labels - deployment.yaml: add missing APP_ prefix to all env var names (runtime bug) - Cargo.toml: remove unused serde_json dependency - src/main.rs: fix misleading comment (INFO → DEBUG default log level) - Dockerfile: use absolute path in ENTRYPOINT - build.sh: fix shebang (sh → bash) to match bash-specific read -p usage - Chart.yaml: replace helm create placeholder appVersion 1.16.0 with 0.0.0 - .devcontainer: update to current mcr.microsoft.com/devcontainers/rust:1-bookworm - devcontainer.json: fix deprecated rust-analyzer.checkOnSave.command setting Co-authored-by: f2calv <16097639+f2calv@users.noreply.github.com> Agent-Logs-Url: https://github.com/f2calv/multi-arch-container-rust/sessions/2d38c791-ae0e-4533-98a2-0094712253fe
…eview feedback +semver:feature - GitVersion.yml: remove copilot branch pattern per reviewer request - Chart.yaml: restore helm-create default appVersion 1.16.0 per reviewer request Co-authored-by: f2calv <16097639+f2calv@users.noreply.github.com> Agent-Logs-Url: https://github.com/f2calv/multi-arch-container-rust/sessions/8bba02fe-79f8-47a6-8242-a74c0edd236e
f2calv
left a comment
There was a problem hiding this comment.
please make an empty commit with +semver:feature to bump this repos tag
Done — empty commit |
src/main.rs: introduceDisplayOption<'a, T>wrapper to eliminateSome("...")rendering and per-iteration allocationsCargo.toml: remove unusedserde_jsondependencyDockerfile: use absolute path in ENTRYPOINTbuild.sh: fix shebang to#!/usr/bin/env bashcharts/multi-arch-container-rust/templates/deployment.yaml: add missingAPP_prefix to all env var names.devcontainer/Dockerfile: update tomcr.microsoft.com/devcontainers/rust:1-bookworm.devcontainer/devcontainer.json: fix deprecatedrust-analyzer.checkOnSave.command→rust-analyzer.check.command.github/workflows/ci.yml: updatechartjob forhelm-chart-package.yml@v1breaking changescargo update)GitVersion.yml: removecopilotbranch pattern per reviewer requestChart.yaml: restoreappVersion: "1.16.0"per reviewer request+semver:featureOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.