Skip to content

Fix ct lint breaking change by relying on upstream workflow fix#109

Closed
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-build-error
Closed

Fix ct lint breaking change by relying on upstream workflow fix#109
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-build-error

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 20, 2026

ct lint was failing with Error: unknown flag: --set because the latest chart-testing image (now v3.14.0) removed --helm-extra-args in v3.12.0. The reusable workflow in f2calv/gha-workflows@v1 has been updated upstream to handle this change, so no pinning is needed in this repository.

This PR is a no-op confirming the upstream fix resolves the build error.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copy link
Copy Markdown
Owner

@f2calv f2calv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream reusable workflow has been updated, revert the change and we see if the workflows complete

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 20, 2026

The upstream reusable workflow has been updated, revert the change and we see if the workflows complete

Reverted in 29dcd77. The chart-testing-cli-version pin has been removed so it will use the default latest again.

Copilot AI changed the title Pin chart-testing to v3.11.0 to fix ct lint breaking change Fix ct lint breaking change by relying on upstream workflow fix Mar 20, 2026
Copilot AI requested a review from f2calv March 20, 2026 20:42
@f2calv f2calv marked this pull request as ready for review March 20, 2026 21:37
Copy link
Copy Markdown
Owner

@f2calv f2calv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now seeing this error;

Error: unknown flag: --set image.tag
unknown flag: --set image.tag
Error: Process completed with exit code 1.

Copilot AI requested a review from f2calv March 20, 2026 21:45
Copilot stopped work on behalf of f2calv due to an error March 20, 2026 21:45
@f2calv
Copy link
Copy Markdown
Owner

f2calv commented Mar 21, 2026

disabled helm chart linting for the time being, will revisit another time

@f2calv f2calv closed this Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants