Add ImGui Minimal Console Feature #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

wizzebit wants to merge 50 commits into f3d-app:master from wizzebit:ImGUI-minimal

wizzebit commented Mar 28, 2025

Addresses #1817

new option ui.minimal_console
minimal console feature added to vtkext/private/module/vtkF3DImguiConsole.cxx

wizzebit added 8 commits

March 22, 2025 21:14


          Added binding for minimal console mode, added option and documentatio…

3ca2e69

…n for minimal console mode


          renamed option, added minimal console behavior

d81f926


          Merge branch 'f3d-app:master' into ImGUI-minimal

721bbd3


          extra functionality, need to make comments

f87d1db


          Merge branch 'f3d-app:master' into ImGUI-minimal

6826c62


          new version of minimal console

8cfc009


          Merge branch 'ImGUI-minimal' of https://github.com/wizzebit/f3d into …

09f411c

…ImGUI-minimal


          updated options.md

afb0c81

github-actions bot reviewed

View reviewed changes

library/src/interactor_impl.cxx Outdated Show resolved Hide resolved

library/src/interactor_impl.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

wizzebit and others added 3 commits

March 28, 2025 06:23


          Update library/src/interactor_impl.cxx

d8da20a

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Update library/src/interactor_impl.cxx

0f8c910

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Update vtkext/private/module/vtkF3DImguiConsole.cxx

4a6968a

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved


          Update vtkext/private/module/vtkF3DImguiConsole.cxx

4cd259b

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved


          Update vtkext/private/module/vtkF3DImguiConsole.cxx

ca8a7a8

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved


          minor fixes

66d100d

github-actions bot reviewed

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

wizzebit added 2 commits

March 28, 2025 17:25


          - changed minimal console format

84830af

- added HideMinimalConsoleEvent
- changed OPTIONS.md description for minimal_console


          Merge branch 'f3d-app:master' into ImGUI-minimal

cb29634

github-actions bot reviewed

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved


          Update vtkext/private/module/vtkF3DImguiConsole.cxx

d264b9d

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.h Outdated Show resolved Hide resolved

wizzebit and others added 2 commits

March 28, 2025 17:43


          Update vtkext/private/module/vtkF3DImguiConsole.h

c920c8b

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Update vtkext/private/module/vtkF3DImguiConsole.h

22d9533

github-actions bot reviewed

View reviewed changes

github-actions bot left a comment

Some suggestions could not be made:

vtkext/private/module/vtkF3DImguiConsole.h
- lines 50-50

wizzebit requested a review from mwestphal

April 4, 2025 11:31

mwestphal reviewed

View reviewed changes

vtkext/private/module/vtkF3DUIActor.h Outdated Show resolved Hide resolved

mwestphal requested changes

View reviewed changes

Member

mwestphal left a comment

small changes needed

wizzebit added 3 commits

April 4, 2025 15:41


          Update vtkF3DUIActor.h

91fb582


          Merge branch 'f3d-app:master' into ImGUI-minimal

30eb9a3


          Added Minimal Console Interaction Tests

307fb93

mwestphal reviewed

View reviewed changes

testing/baselines/TestInteractionMinimalConsoleResize.png Outdated Show resolved Hide resolved

mwestphal reviewed

View reviewed changes

application/testing/CMakeLists.txt Outdated Show resolved Hide resolved

mwestphal requested changes

View reviewed changes

Member

mwestphal left a comment

small change needed

wizzebit added 3 commits

April 16, 2025 17:18


          Merge branch 'f3d-app:master' into ImGUI-minimal

5bf6f95


          -modified console badge position to be level with minimal console

f88ea06

-changed valid command test to use set_camera top


          Merge branch 'ImGUI-minimal' of https://github.com/wizzebit/f3d into …

1ded2e3

…ImGUI-minimal

github-actions bot reviewed

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved


          Update vtkext/private/module/vtkF3DImguiConsole.cxx

42b6a77

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

wizzebit requested a review from mwestphal

April 16, 2025 21:39

mwestphal reviewed

View reviewed changes

application/testing/CMakeLists.txt Outdated Show resolved Hide resolved

mwestphal reviewed

View reviewed changes

testing/recordings/TestInteractionMinimalConsoleBadgeRemains.log Show resolved Hide resolved

mwestphal reviewed

View reviewed changes

vtkext/private/module/vtkF3DImguiConsole.cxx Outdated Show resolved Hide resolved

mwestphal requested changes

View reviewed changes

Member

mwestphal left a comment

some changes and questions

wizzebit added 2 commits

April 17, 2025 18:31


          Merge branch 'f3d-app:master' into ImGUI-minimal

9c04f36


          - Shortened log code

d82aa90

- Fixed invalid command test

Member

mwestphal commented Apr 21, 2025

So after discussion, lets move the minimal console up, aligned with console badge

wizzebit added 2 commits

April 22, 2025 11:36


          Merge branch 'f3d-app:master' into ImGUI-minimal

21f8774


          changed minimal console position and size

882ba5e

changed test baseline images

mwestphal reviewed

View reviewed changes

testing/baselines/TestInteractionMinimalConsoleOpen.png Outdated Show resolved Hide resolved

mwestphal reviewed

View reviewed changes

testing/recordings/TestInteractionMinimalConsoleBadgeRemains.log Outdated Show resolved Hide resolved

mwestphal reviewed

View reviewed changes

testing/recordings/TestInteractionMinimalConsoleEscape.log Outdated Show resolved Hide resolved

mwestphal requested changes

View reviewed changes

Member

mwestphal left a comment

a few last nitpicks :)


          made minimal console resize when badge and updated test

ab5bba9

added end of line to minimal console tests

wizzebit requested a review from mwestphal

April 23, 2025 19:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet