Skip to content

Add Axis Rotation Support#2396

Draft
dh-you wants to merge 22 commits intof3d-app:masterfrom
dh-you:master
Draft

Add Axis Rotation Support#2396
dh-you wants to merge 22 commits intof3d-app:masterfrom
dh-you:master

Conversation

@dh-you
Copy link
Contributor

@dh-you dh-you commented Jul 11, 2025

Describe your changes

Add support for Axis rotation #2063

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated timestamp

Continuous integration

Please check the checkbox of the CI you want to run, then push again on your branch.

  • Style checks
  • Fast CI
  • Coverage cached CI
  • Analysis cached CI
  • WASM docker CI
  • Android docker CI
  • macOS Intel cached CI
  • macOS ARM cached CI
  • Windows cached CI
  • Linux cached CI
  • Other cached CI

@mwestphal
Copy link
Member

mwestphal commented Jul 24, 2025

Hi @dh-you ! How is it going ? Do you need any help moving forward ?

@dh-you
Copy link
Contributor Author

dh-you commented Jul 24, 2025

Sorry, I've been busy lately, but I'll try to get you something by this weekend.

@mwestphal
Copy link
Member

mwestphal commented Jul 31, 2025

Hey @dh-you , please ask for a review when needed :)

mwestphal
mwestphal reviewed Jul 31, 2025
View reviewed changes
mwestphal
mwestphal reviewed Jul 31, 2025
View reviewed changes
mwestphal
mwestphal reviewed Jul 31, 2025
View reviewed changes
mwestphal
mwestphal reviewed Jul 31, 2025
View reviewed changes
mwestphal
mwestphal reviewed Jul 31, 2025
View reviewed changes
@dh-you dh-you marked this pull request as ready for review July 31, 2025 19:52
@dh-you dh-you marked this pull request as draft July 31, 2025 19:52
@dh-you dh-you requested a review from mwestphal July 31, 2025 19:52
mwestphal
mwestphal reviewed Aug 1, 2025
View reviewed changes
mwestphal
mwestphal requested changes Aug 1, 2025
View reviewed changes
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not implemented as expected im afraid

@dh-you dh-you requested a review from mwestphal August 2, 2025 12:45
Meakk
Meakk reviewed Aug 8, 2025
View reviewed changes
@dh-you dh-you requested a review from Meakk August 20, 2025 00:41
mwestphal
mwestphal requested changes Aug 20, 2025
View reviewed changes
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feature is non-fonctionnal. Please test locally before asking for a review.

@mwestphal mwestphal removed the request for review from Meakk August 20, 2025 08:37
@dh-you dh-you requested a review from mwestphal September 17, 2025 00:42
mwestphal
mwestphal requested changes Sep 18, 2025
View reviewed changes
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice first prototype!

@dh-you dh-you requested a review from mwestphal September 25, 2025 21:55
mwestphal
mwestphal reviewed Sep 26, 2025
View reviewed changes
library/src/interactor_impl.cxx
{
return std::make_pair(doc,
(opts.interactor.axis_lock &&
val == this->Internals->Options.getAsString("interactor.axis_lock"))
Copy link
Member

@mwestphal mwestphal Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be cleaner to not use string here I think, can you use direction_t directly to compare against ?

mwestphal
mwestphal reviewed Sep 26, 2025
View reviewed changes
mwestphal
mwestphal reviewed Sep 26, 2025
View reviewed changes
mwestphal
mwestphal reviewed Sep 26, 2025
View reviewed changes
vtkext/private/module/vtkF3DRenderer.h
Comment on lines +591 to +592
bool UseRotationAxis = false;
double RotationAxis[3] = { 0.0, 0.0, 0.0 };
Copy link
Member

@mwestphal mwestphal Sep 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just store this as an std::optional<std::array<double, 3>>

dh-you and others added 2 commits September 26, 2025 08:21
@dh-you @mwestphal
Update vtkF3DRenderer.h
2b2a9ac 
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
@dh-you @mwestphal
Update vtkF3DRenderer.h
a01a29d 
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
@mwestphal
Copy link
Member

mwestphal commented Oct 5, 2025

Need any help moving forward @dh-you ?

@dh-you
Copy link
Contributor Author

dh-you commented Oct 14, 2025

Hi, sorry for the delay. Ive been busy with school lately. I will try to make the changes by end of week.

@mwestphal
Copy link
Member

mwestphal commented Nov 1, 2025

Do you need a review @dh-you ? :)

@mwestphal
Copy link
Member

mwestphal commented Nov 8, 2025

Need any help moving forward @dh-you ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwestphal mwestphal mwestphal requested changes

@Meakk Meakk Meakk left review comments

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

triage:stalled

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dh-you @mwestphal @Meakk