scene hierarchy prototype#2509

Open

Medyan-Naser wants to merge 38 commits intof3d-app:masterfrom

Medyan-Naser:feature/scene-hierarchy-prototype-2491

Contributor

Medyan-Naser commented Oct 12, 2025

Describe your changes

Create prototype of scene hierarchy display and control using the vtkGLTFImporter

Issue ticket number and link if any

Checklist for finalizing the PR

I have performed a self-review of my code
I have added tests for new features and bugfixes
I have added documentation for new features
If it is a modifying the libf3d API, I have updated bindings
If it is a modifying the .github/workflows/versions.json, I have updated timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

github-actions bot commented Oct 12, 2025 •

edited

Loading

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: c, python, java, webassembly.

mwestphal mentioned this pull request

Create prototype of scene hierarchy display and control using the vtkGLTFImporter #2491

Closed

Medyan-Naser force-pushed the feature/scene-hierarchy-prototype-2491 branch from 0850d02 to 32a17a9 Compare

November 11, 2025 00:29

mwestphal reviewed

View reviewed changes

library/CMakeLists.txt Outdated Show resolved Hide resolved

mwestphal reviewed

View reviewed changes

vtkext/private/module/F3DNodeInfo.h Show resolved Hide resolved

mwestphal reviewed

View reviewed changes

vtkext/private/module/vtkF3DRenderer.h Outdated Show resolved Hide resolved

mwestphal reviewed

View reviewed changes

library/public/scene.h Outdated Show resolved Hide resolved

mwestphal reviewed

View reviewed changes

library/public/window.h Outdated Show resolved Hide resolved

Medyan-Naser force-pushed the feature/scene-hierarchy-prototype-2491 branch from 37cdf50 to 979aaf2 Compare

November 28, 2025 00:26

Member

mwestphal commented Nov 28, 2025

Please ask for a review when needed @Medyan-Naser :)

Medyan-Naser force-pushed the feature/scene-hierarchy-prototype-2491 branch from 979aaf2 to 14d6e13 Compare

December 13, 2025 17:52

Medyan-Naser requested a review from mwestphal

December 13, 2025 17:52

Contributor Author

Medyan-Naser commented Dec 13, 2025

@mwestphal
I’m back to working on this PR. I’ve rebased it to master and addressed the comments you mentioned earlier. Please review when you have a chance.

mwestphal reviewed

View reviewed changes

library/CMakeLists.txt Outdated Show resolved Hide resolved

mwestphal reviewed

View reviewed changes

vtkext/private/module/vtkF3DImguiActor.h Outdated Show resolved Hide resolved

mwestphal reviewed

View reviewed changes

vtkext/private/module/vtkF3DMetaImporter.cxx Outdated Show resolved Hide resolved

mwestphal reviewed

View reviewed changes

vtkext/private/module/vtkF3DRenderer.cxx Outdated Show resolved Hide resolved

mwestphal requested changes

View reviewed changes

Member

mwestphal left a comment

changes needed

Member

mwestphal commented Jan 3, 2026

Hi @Medyan-Naser

Still working on this ? :)

mwestphal linked an issue

that may be closed by this pull request

Add model/material/hierarchy and information #18

Open

Medyan-Naser force-pushed the feature/scene-hierarchy-prototype-2491 branch from 14d6e13 to f1c0109 Compare

January 20, 2026 03:22

Contributor Author

Medyan-Naser commented Jan 25, 2026

Sorry for the late reply.
I addressed all of your comment and updated the code. Please review my changes.

Medyan-Naser requested a review from mwestphal

January 29, 2026 00:24

Member

mwestphal commented Jan 29, 2026

Hi @mwestphal,

Sorry for the late reply. I addressed all of your comment and updated the code. Please review my changes.

please first resolve the conversations you have adressed :)

Member

mwestphal commented Jan 29, 2026

Also please fix the conflict with master.

mwestphal reviewed

View reviewed changes

Member

mwestphal left a comment

changes needed before a review.

Medyan-Naser force-pushed the feature/scene-hierarchy-prototype-2491 branch from 873720b to fab46b2 Compare

January 29, 2026 23:20

Contributor Author

Medyan-Naser commented Jan 29, 2026

I've rebased with master and resolved all comments, except for the one regarding file types. Since we use "vtkF3DGLTFImporter.h", GLTF files can have multiple actors with individual visibility toggles, whereas other file types will currently be limited to a single actor for the whole model.
Please let me know your thoughts on this implementation.

Medyan-Naser requested a review from mwestphal

January 29, 2026 23:41

Member

mwestphal commented Jan 30, 2026

I've rebased with master and resolved all comments, except for the one regarding file types. Since we use "vtkF3DGLTFImporter.h", GLTF files can have multiple actors with individual visibility toggles, whereas other file types will currently be limited to a single actor for the whole model. Please let me know your thoughts on this implementation.

Indeed, thats fait, we will need to create an issue to list all the importer that needs to be improved though, I will take care of it.

Medyan-Naser added 29 commits

February 28, 2026 14:48


          move struct NodeInfo to one place

6f70ecf


          improve VTK render after hiding an actor

35fe204


          use requestRender() API

a393a26


          fix rebase issues


          remove unused lines

5528f67


          calc hierarchy menu width

040ccf4


          address comments

3e4e527


          rebase with master

b04848b


          address comments and remove SetRenderRequestCallback

b0d0e68


          makes the hide/unhide apply immediately after you click

325cac7


          fix cmakelist file

26a076c


          resolve comments and remove unused lines

54fe4cd


          remove empty lines

e4d884c


          fix architecture dependencies

87d2939


          render twice for mouse clicks

84e3962


          remove empty line

9e34463


          remove unused parameter

c63dbbc


          add a call to a render request for checkbox

8f54a57


          use OnUIEvent for double render

06a6931


          remove empty lines

b4fae0b


          simplify GetSceneHierarchyNodes

46fbeec


          resolve comments

db59a5e


          add tests for new scene-hierarchy feature

88cac2c


          address comments

fa020fa

rebase


          use InterpolationTest.glb for test

4c0c31a


          Always sync visibility state from the actual actor


          show full hierarchy

58972e3


          Visibility preserved regardless of display mode changes

f4d0326


          remove unused code

1ad4337

Medyan-Naser force-pushed the feature/scene-hierarchy-prototype-2491 branch from 5379f8c to 1ad4337 Compare

February 28, 2026 19:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet