-
-
Notifications
You must be signed in to change notification settings - Fork 361
Do not throw if cache path is empty #2752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is surely a test to update.
Also, what is the behavior when there is no cache path then ?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2752 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 142 142
Lines 12918 12923 +5
=======================================
+ Hits 12487 12492 +5
Misses 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question
Describe your changes
On Android, caches are local to app, so it's the app responsibility to set the cache path using
f3d::engine::setCachePathright after engine initialization.Do not throw if the cache path cannot be retrieved using env vars.
Supersedes #2024
Issue ticket number and link if any
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.