DRAFT PR: adding interpolation to QuakeMDL animations with vtkInterpolateDataSe…#2775
Open
The-Lennzer wants to merge 2 commits intof3d-app:masterfrom
Open
DRAFT PR: adding interpolation to QuakeMDL animations with vtkInterpolateDataSe…#2775The-Lennzer wants to merge 2 commits intof3d-app:masterfrom
The-Lennzer wants to merge 2 commits intof3d-app:masterfrom
Conversation
mwestphal
reviewed
Jan 5, 2026
|
|
||
| // Calculate interpolation factor (alpha) | ||
| double alpha = 0.0; | ||
| if (frameIndex0 != frameIndex1 && (t1 - t0) > 1e-9) |
Author
There was a problem hiding this comment.
In order to make sure that the two frames are unique. 1e-9 is really strict. I think we can remove this check as well if you think that's okay.
mwestphal
reviewed
Jan 5, 2026
|
|
||
| vtkIdType ActiveAnimation = -1; | ||
|
|
||
| vtkSmartPointer<vtkInterpolateDataSetAttributes> Interpolator; |
Member
There was a problem hiding this comment.
Suggested change
| vtkSmartPointer<vtkInterpolateDataSetAttributes> Interpolator; | |
| vtkNew<vtkInterpolateDataSetAttributes> Interpolator; |
mwestphal
reviewed
Jan 5, 2026
| { | ||
| this->Internals->Texture->SetInputData(this->Internals->GroupSkins[animIndex][frameIndex]); | ||
| // For texture animations, use nearest neighbor approach | ||
| // Not interpolating here since texture interpolation is complex(?) |
Member
|
please resolve adressed discussions and ask me for a review @The-Lennzer when its ready :) |
Member
|
Still working on this @The-Lennzer ? |
Author
|
Yes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tAttributes
Issue: #2138
Describe your changes
#include <vtkInterpolateDataSetAttributes.h>vtkSmartPointer<vtkInterpolateDataSetAttributes> InterpolatorDRAFT PR for reviewing code not to be merged!