Move FPS timer to top-right, next to console badge#2822
Move FPS timer to top-right, next to console badge#2822dhimasardinata wants to merge 5 commits intof3d-app:masterfrom
Conversation
dhimasardinata
force-pushed
the
fix/fps-timer-position
branch
from
5b80333 to
68962f9
Compare
|
Hi @dhimasardinata , I think this can be integrated easily, are you around If I review soon ? |
|
@mwestphal sure, I'm around 👍 |
|
Please comment on #2803 so I can assign it to you |
mwestphal
left a comment
mwestphal
left a comment
There was a problem hiding this comment.
please comment on the issue.
|
Nice! You need to update test baselines to account for the move, do you know how to do that ? |
|
Thanks for the heads up! I've updated the TestFPS baseline and verified that all tests are passing now. Let me know if you spot anything else! |
Im afraid the test is not right because it would result in a different image each time. A solution is to use Let me know if you need help. |
Only offset the FPS counter when the console badge is visible and use the badge size for spacing. Also reduce font scale for TestFPS and update baseline.
|
I updated the FPS offset so it only shifts when the badge is actually visible, and I used the badge size for spacing. I also added --font-scale=0.5 to TestFPS, refreshed the baseline, and re-ran it locally. |
Nice! Let see how CI goes. |
|
\ci fast |
|
\ci full |
Put console badge lookup on a single line to match formatting.
Use Crosterian test font with a smaller scale for TestFPS and update the baseline.
| void ShowBadge(); | ||
|
|
||
| /** | ||
| * Check if the console badge is visible |
There was a problem hiding this comment.
| * Check if the console badge is visible | |
| * Return true if the console badge is visible, false otherwise |
|
@dhimasardinata let me know if you need help making the test work, dont hesitate to join the discord to discuss: https://discord.f3d.app |
|
@mwestphal hey, yes i need help getting the test to work😅 thanks! |
|
Just increase the threshold of the test ? |
2 participants
Move the FPS timer from the bottom-left (where it overlaps with the Axis widget X) to the top-right corner, next to the console badge.
When the console badge is visible, the FPS timer is positioned to its left with standard padding. When the console badge is not visible, it is positioned at the screen edge.
Fixes #2803