Conversation
Meakk
force-pushed
the
scene-hierarchy
branch
3 times, most recently
from
0c380e0 to
5ad0007
Compare
| } | ||
|
|
||
| //---------------------------------------------------------------------------- | ||
| void vtkF3DRenderer::ConfigureColoring() |
There was a problem hiding this comment.
maybe mention in the doc of this method that it is also responsible for handling visiblity.
It already was before, I know, but now it is way more explicit.
Unless we want to split actor visibility in another method to avoid redoing the whole coloring logic on visibility change.
There was a problem hiding this comment.
I don't think we want to split because if we turn on visibility, we need to go through the coloring function to know which actor visibility to enable.
There was a problem hiding this comment.
why though ? coloring and visibility are two difference concepts, are they not.
There was a problem hiding this comment.
Because ConfigureColoring() switch visibility between the original actor and the colored one.
| if (this->SceneHierarchyVisible != show) | ||
| { | ||
| this->SceneHierarchyVisible = show; | ||
| this->UIActor->SetSceneHierarchyVisibility(show); |
There was a problem hiding this comment.
better to handle that in a simple ConfureSceneHierachy method, similar to ConfigureMetaData above.
| return result; | ||
| } | ||
|
|
||
| class vtkF3DVisibilityDataAssemblyVisitor : public vtkDataAssemblyVisitor |
There was a problem hiding this comment.
I dont fully understand the logic of this visitor.
Can you explain (and documment in comment) how it works ? :)
There was a problem hiding this comment.
I've added comments before each visitor, let me know if it makes more sense.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2915 +/- ##
==========================================
+ Coverage 96.99% 97.10% +0.11%
==========================================
Files 204 204
Lines 16221 16355 +134
==========================================
+ Hits 15733 15882 +149
+ Misses 488 473 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
Describe your changes
Left for future work:
f3d::sceneAPI to retrieve the scene hierarchyf3d::sceneAPI to change a node visibilityIssue ticket number and link if any
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.