Add backdrop.color libf3d and f3 d option by PedroAbreuMaia · Pull Request #2956 · f3d-app/f3d

PedroAbreuMaia · 2026-03-19T14:10:31Z

Describe your changes

Added libf3d option ui.backdrop.color option to control backdrop color.
Added a CLI option to control it --backdrop-color
This option is set black by default.
Added new tests.

Issue ticket number and link if any

#2861

Checklist for finalizing the PR

I have performed a self-review of my code
I have added tests for new features and bugfixes
I have added documentation for new features
If it is a modifying the libf3d API, I have updated bindings
If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

…ole and application options.

mwestphal

let me know when you need a review @PedroAbreuMaia

mwestphal · 2026-03-22T20:42:18Z

@PedroAbreuMaia please do not merge with master, but use rebase instead:

mwestphal · 2026-03-22T20:45:02Z

+f3d_test(NAME TestBackdropColorRed DATA suzanne.ply ARGS -n --backdrop-color=1.0,0.0,0.0 UI)
+f3d_test(NAME TestBackdropColorGreen DATA suzanne.ply ARGS -n --backdrop-color=0.0,1.0,0.0 UI)
+f3d_test(NAME TestBackdropColorBlue DATA suzanne.ply ARGS -n --backdrop-color=0.0,0.0,1.0 UI)
+f3d_test(NAME TestBackdropColorWhite DATA suzanne.ply ARGS -n --backdrop-color=1.0,1.0,1.0 UI)


no need to test all the colors, just a single test is fine, ideally not a full color (like 1,0,0) but something else.

mwestphal · 2026-03-22T20:45:33Z

  ImGui::SetNextWindowSizeConstraints(
    ImVec2(10.f, winHeight), ImVec2(std::numeric_limits<float>::max(), winHeight));
-  ImGui::SetNextWindowBgAlpha(this->BackdropOpacity);
+  //ImGui::SetNextWindowBgAlpha(this->BackdropOpacity);


delete this

mwestphal · 2026-03-22T20:45:40Z


    ::SetupNextWindow(ImVec2(viewport->GetWorkCenter().x - 0.5f * totalWidth, margin), winSize);
-    ImGui::SetNextWindowBgAlpha(this->BackdropOpacity);
+    //ImGui::SetNextWindowBgAlpha(this->BackdropOpacity);


delete this

mwestphal · 2026-03-22T20:45:47Z

                      viewport->GetWorkCenter().y - 0.5f * winSize.y),
    winSize);
-  ImGui::SetNextWindowBgAlpha(this->BackdropOpacity);
+  //ImGui::SetNextWindowBgAlpha(this->BackdropOpacity);


delete this

mwestphal · 2026-03-22T20:45:53Z

    ::SetupNextWindow(
      ImVec2(viewport->GetWorkCenter().x - 0.5f * totalWidth + winOffsetX, margin), winSize);
-    ImGui::SetNextWindowBgAlpha(this->BackdropOpacity);
+    //ImGui::SetNextWindowBgAlpha(this->BackdropOpacity);


delete this

mwestphal · 2026-03-22T20:45:59Z

    ImVec2(
      this->Pimpl->CheatSheetWidth, std::min(viewport->WorkSize.y - (2 * margin), textHeight)));
-  ImGui::SetNextWindowBgAlpha(this->BackdropOpacity);
+  //ImGui::SetNextWindowBgAlpha(this->BackdropOpacity);


delete this

mwestphal · 2026-03-22T20:46:05Z


  ::SetupNextWindow(position, winSize);
-  ImGui::SetNextWindowBgAlpha(this->BackdropOpacity);
+  //ImGui::SetNextWindowBgAlpha(this->BackdropOpacity);


delete this

mwestphal · 2026-03-22T20:46:15Z

   */
  void SetBackdropOpacity(const double backdropOpacity);

+  void SetBackdropColor(const std::array<double, 3>& color);


add doxygen doc

This is just to add the doxygen annotations?

yes, please :)

mwestphal · 2026-03-22T20:46:28Z

+    this->BackdropColor = color;
+    this->Initialized = false;
+  }
+}


missing end of line at the end of the file

mwestphal · 2026-03-22T20:48:40Z

\ci fast

mwestphal

small changes needed. Let me know if anything is unclear :)

I've also run the fast CI to see if it finds anything.

github-actions · 2026-03-22T20:49:26Z

Style Checks CI failed:

diff --git a/library/src/window_impl.cxx b/library/src/window_impl.cxx
index d3fe715..faf12c5 100644
--- a/library/src/window_impl.cxx
+++ b/library/src/window_impl.cxx
@@ -470,7 +470,7 @@ void window_impl::UpdateDynamicOptions()
   {
     f3d::color_t color = opt.ui.backdrop.color.value();
     renderer->SetBackdropColor({ color[0], color[1], color[2] });
-  }  
+  }
 
   if (this->Internals->Interactor)
   {

…thub.com/PedroAbreuMaia/f3d into Add-backdrop.color-libf3d-and-F3D-option

…ole and application options.

…thub.com/PedroAbreuMaia/f3d into Add-backdrop.color-libf3d-and-F3D-option

…ole and application options.

Co-authored-by: Archie Payne <115465107+ArchiePayne@users.noreply.github.com>

* do not set axes grid center position * update test interaction * Not use interaction test * do not set axes grid center position * update test interaction * Not use interaction test

…ole and application options.

Co-authored-by: Archie Payne <115465107+ArchiePayne@users.noreply.github.com>

mwestphal · 2026-03-26T06:13:08Z

Looks like the merge/rebase did not went well, do you need help with that ?

PedroAbreuMaia · 2026-03-26T11:00:06Z

Yes, please. I've been trying to do it last night and could not figure it out.

mwestphal · 2026-03-26T19:28:29Z

here is your branch rebase on master: #2975

Let me know if you need help recover it locally and force pushing to your fork.

PedroAbreuMaia · 2026-03-29T20:26:18Z

I pulled the one you created locally, but I could not force push it. So I colse that branch and push the local one to its place. Should I open a new PR?

mwestphal · 2026-03-29T21:17:08Z

there is no reason that you could not force pus on your own fork, but as you prefer :)

PedroAbreuMaia · 2026-03-29T21:27:34Z

Still, should I open a new PR? Or use the one you opened? And how do get the PR reviewed?

mwestphal · 2026-03-30T06:18:32Z

Still, should I open a new PR?

Yes

Or use the one you opened?

That you cannot.

And how do get the PR reviewed?

Once you created the PR, you will be able to request a review, it is all documented here: https://f3d.app/dev/CONTRIBUTING#f3d-development-workflow

PedroAbreuMaia added 4 commits March 19, 2026 09:57

Add the tests to validate feature.

0d357d6

Add the color option to ui backdrop and the way to change it via cons…

fbd89b1

…ole and application options.

Add the backdrop color, and functions to change it to the FD3 modules.

483aeef

Add the baseline images to validate the previously added tests.

15c92bb

mwestphal self-requested a review March 22, 2026 12:28

mwestphal requested changes Mar 22, 2026

View reviewed changes

mwestphal linked an issue Mar 22, 2026 that may be closed by this pull request

Add backdrop.color libf3d and F3D option #2861

Open

Merge branch 'master' into Add-backdrop.color-libf3d-and-F3D-option

168ffeb

PedroAbreuMaia marked this pull request as ready for review March 22, 2026 16:00

mwestphal self-requested a review March 22, 2026 20:43

mwestphal reviewed Mar 22, 2026

View reviewed changes

mwestphal added the ci:fast label Mar 22, 2026

mwestphal requested changes Mar 22, 2026

View reviewed changes

PedroAbreuMaia added 6 commits March 25, 2026 22:30

Make the corrections requested to PR

dc81154

Merge branch 'Add-backdrop.color-libf3d-and-F3D-option' of https://gi…

494c251

…thub.com/PedroAbreuMaia/f3d into Add-backdrop.color-libf3d-and-F3D-option

Add the tests to validate feature.

2b4bd48

Add the color option to ui backdrop and the way to change it via cons…

26a1a27

…ole and application options.

Add the backdrop color, and functions to change it to the FD3 modules.

1242dc8

Add the baseline images to validate the previously added tests.

e3a0f2b

PedroAbreuMaia and others added 17 commits March 25, 2026 23:30

Merge branch 'Add-backdrop.color-libf3d-and-F3D-option' of https://gi…

3186745

…thub.com/PedroAbreuMaia/f3d into Add-backdrop.color-libf3d-and-F3D-option

Add the tests to validate feature.

e24b5a1

Add the color option to ui backdrop and the way to change it via cons…

fd3aafa

…ole and application options.

Add the backdrop color, and functions to change it to the FD3 modules.

2262808

Add the baseline images to validate the previously added tests.

822ef11

Make the corrections requested to PR

3da6c7f

Fix HDRI cache and log forwarder on Android (f3d-app#2955)

48bd5dc

CMake: Fix static VTK build with pdal plugin (f3d-app#2959)

9d0e292

Normal rendering mode (f3d-app#2958)

5ad2cec

Co-authored-by: Archie Payne <115465107+ArchiePayne@users.noreply.github.com>

[Fix] Do not set axes grid center position f3d-app#2824 (f3d-app#2947)

fb43738

* do not set axes grid center position * update test interaction * Not use interaction test * do not set axes grid center position * update test interaction * Not use interaction test

Add the tests to validate feature.

e0eb851

Add the color option to ui backdrop and the way to change it via cons…

e3a9ac2

…ole and application options.

Add the backdrop color, and functions to change it to the FD3 modules.

00fe7ef

Add the baseline images to validate the previously added tests.

d52e2b7

Make the corrections requested to PR

b11feee

Normal rendering mode (f3d-app#2958)

0f2df71

Co-authored-by: Archie Payne <115465107+ArchiePayne@users.noreply.github.com>

Fix the conflicts

540971d

mwestphal self-requested a review March 26, 2026 17:05

mwestphal removed their request for review March 26, 2026 19:28

PedroAbreuMaia closed this Mar 29, 2026

PedroAbreuMaia deleted the Add-backdrop.color-libf3d-and-F3D-option branch March 29, 2026 20:16

PedroAbreuMaia restored the Add-backdrop.color-libf3d-and-F3D-option branch March 29, 2026 20:20

PedroAbreuMaia deleted the Add-backdrop.color-libf3d-and-F3D-option branch March 29, 2026 20:23

Uh oh!

Conversation

PedroAbreuMaia commented Mar 19, 2026 • edited by mwestphal Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes

Issue ticket number and link if any

Checklist for finalizing the PR

Continuous integration

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

mwestphal commented Mar 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwestphal commented Mar 22, 2026

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mwestphal commented Mar 26, 2026

Uh oh!

PedroAbreuMaia commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mwestphal commented Mar 26, 2026

Uh oh!

PedroAbreuMaia commented Mar 29, 2026

Uh oh!

mwestphal commented Mar 29, 2026

Uh oh!

PedroAbreuMaia commented Mar 29, 2026

Uh oh!

mwestphal commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PedroAbreuMaia commented Mar 19, 2026 •

edited by mwestphal

Loading

github-actions Bot commented Mar 22, 2026 •

edited

Loading

PedroAbreuMaia commented Mar 26, 2026 •

edited

Loading