Issue - 3006#3040
Conversation
mwestphal
left a comment
mwestphal
left a comment
There was a problem hiding this comment.
thanks for opening this PR, please request a review whenever you need :)
|
\ci fast |
| `roll_camera value`: A specific command to roll the camera on its side, takes an angle in degrees as an argument. | ||
| eg: `roll_camera 120`. | ||
|
|
||
| `set camera_position x y z`: A specific command to set the position of the camera to the position of x y z. |
There was a problem hiding this comment.
there should be a single set_camera command that suppot both x,y,z and top/bottom
|
@Meakk could you review this? Its a bit late and I cant figure out how to request anyone outside of the suggested users to review so thats why im writing this over comment. Thank you! |
Meakk
left a comment
Meakk
left a comment
There was a problem hiding this comment.
Looks ok. However I'm wondering if it shouldn't be a new command set_camera_position instead of extending the existing set_camera.
You will also need to create an application test similar to TestCommandScriptSetCameraLeft
| { | ||
| this->Internals->SetViewOrbit(internals::ViewType::VT_ISOMETRIC); | ||
| this->Internals->Style->ResetTemporaryUp(); | ||
| check_args(args, 3, "set_camera"); |
There was a problem hiding this comment.
check_args calls here and above are not needed anymore.
4 participants
Describe your changes
Issue ticket number and link if any
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.