Skip to content

Prevent scene hierarchy widget rescaling on left border #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lilac0o0 wants to merge 1 commit into
base: master
Choose a base branch
from
+178 −1
Open

Prevent scene hierarchy widget rescaling on left border #3062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
164 changes: 164 additions & 0 deletions testing/recordings/TestLeftBorderInteractionRemovalOnHierarchyWindow.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,164 @@
# StreamVersion 1.2
# Test Hierarchy window: test to check for no interaction with the left window border when resizing
RenderEvent 0 0 0 0 0 0 0
LeftButtonPressEvent 7 295 0 0 0 0 0
TimerEvent 7 295 0 0 0 0 0
TimerEvent 7 295 0 0 0 0 0
TimerEvent 7 295 0 0 0 0 0
TimerEvent 7 295 0 0 0 0 0
TimerEvent 7 295 0 0 0 0 0
MouseMoveEvent 8 295 0 0 0 0 0
TimerEvent 8 295 0 0 0 0 0
MouseMoveEvent 9 295 0 0 0 0 0
MouseMoveEvent 17 296 0 0 0 0 0
MouseMoveEvent 23 296 0 0 0 0 0
MouseMoveEvent 35 296 0 0 0 0 0
TimerEvent 35 296 0 0 0 0 0
MouseMoveEvent 49 296 0 0 0 0 0
MouseMoveEvent 63 296 0 0 0 0 0
MouseMoveEvent 75 296 0 0 0 0 0
MouseMoveEvent 88 294 0 0 0 0 0
TimerEvent 88 294 0 0 0 0 0
MouseMoveEvent 96 292 0 0 0 0 0
MouseMoveEvent 103 291 0 0 0 0 0
MouseMoveEvent 107 291 0 0 0 0 0
MouseMoveEvent 112 291 0 0 0 0 0
TimerEvent 112 291 0 0 0 0 0
MouseMoveEvent 116 291 0 0 0 0 0
MouseMoveEvent 122 291 0 0 0 0 0
MouseMoveEvent 128 291 0 0 0 0 0
MouseMoveEvent 135 291 0 0 0 0 0
TimerEvent 135 291 0 0 0 0 0
MouseMoveEvent 143 291 0 0 0 0 0
MouseMoveEvent 149 291 0 0 0 0 0
MouseMoveEvent 155 291 0 0 0 0 0
MouseMoveEvent 161 291 0 0 0 0 0
MouseMoveEvent 166 291 0 0 0 0 0
MouseMoveEvent 172 291 0 0 0 0 0
TimerEvent 172 291 0 0 0 0 0
MouseMoveEvent 178 291 0 0 0 0 0
MouseMoveEvent 184 291 0 0 0 0 0
MouseMoveEvent 190 291 0 0 0 0 0
MouseMoveEvent 197 291 0 0 0 0 0
TimerEvent 197 291 0 0 0 0 0
MouseMoveEvent 205 291 0 0 0 0 0
MouseMoveEvent 215 291 0 0 0 0 0
MouseMoveEvent 223 291 0 0 0 0 0
MouseMoveEvent 233 291 0 0 0 0 0
TimerEvent 233 291 0 0 0 0 0
MouseMoveEvent 243 291 0 0 0 0 0
MouseMoveEvent 255 290 0 0 0 0 0
MouseMoveEvent 264 287 0 0 0 0 0
MouseMoveEvent 274 285 0 0 0 0 0
TimerEvent 274 285 0 0 0 0 0
MouseMoveEvent 285 284 0 0 0 0 0
MouseMoveEvent 293 281 0 0 0 0 0
MouseMoveEvent 302 279 0 0 0 0 0
TimerEvent 302 279 0 0 0 0 0
MouseMoveEvent 310 278 0 0 0 0 0
MouseMoveEvent 319 277 0 0 0 0 0
MouseMoveEvent 325 275 0 0 0 0 0
MouseMoveEvent 330 274 0 0 0 0 0
TimerEvent 330 274 0 0 0 0 0
MouseMoveEvent 333 273 0 0 0 0 0
MouseMoveEvent 335 273 0 0 0 0 0
MouseMoveEvent 338 273 0 0 0 0 0
MouseMoveEvent 341 273 0 0 0 0 0
TimerEvent 341 273 0 0 0 0 0
MouseMoveEvent 343 273 0 0 0 0 0
MouseMoveEvent 345 273 0 0 0 0 0
MouseMoveEvent 347 273 0 0 0 0 0
MouseMoveEvent 350 272 0 0 0 0 0
TimerEvent 350 272 0 0 0 0 0
MouseMoveEvent 351 272 0 0 0 0 0
MouseMoveEvent 352 272 0 0 0 0 0
MouseMoveEvent 354 272 0 0 0 0 0
MouseMoveEvent 356 271 0 0 0 0 0
TimerEvent 356 271 0 0 0 0 0
MouseMoveEvent 357 271 0 0 0 0 0
MouseMoveEvent 359 271 0 0 0 0 0
TimerEvent 359 271 0 0 0 0 0
MouseMoveEvent 362 270 0 0 0 0 0
MouseMoveEvent 364 270 0 0 0 0 0
MouseMoveEvent 367 269 0 0 0 0 0
MouseMoveEvent 370 268 0 0 0 0 0
TimerEvent 370 268 0 0 0 0 0
MouseMoveEvent 374 267 0 0 0 0 0
MouseMoveEvent 376 267 0 0 0 0 0
MouseMoveEvent 379 267 0 0 0 0 0
MouseMoveEvent 382 265 0 0 0 0 0
TimerEvent 382 265 0 0 0 0 0
MouseMoveEvent 383 265 0 0 0 0 0
MouseMoveEvent 385 265 0 0 0 0 0
MouseMoveEvent 387 265 0 0 0 0 0
MouseMoveEvent 389 265 0 0 0 0 0
TimerEvent 389 265 0 0 0 0 0
MouseMoveEvent 392 265 0 0 0 0 0
MouseMoveEvent 396 264 0 0 0 0 0
MouseMoveEvent 397 264 0 0 0 0 0
MouseMoveEvent 399 264 0 0 0 0 0
MouseMoveEvent 401 264 0 0 0 0 0
MouseMoveEvent 403 263 0 0 0 0 0
TimerEvent 403 263 0 0 0 0 0
MouseMoveEvent 404 262 0 0 0 0 0
MouseMoveEvent 405 262 0 0 0 0 0
MouseMoveEvent 406 262 0 0 0 0 0
TimerEvent 406 262 0 0 0 0 0
TimerEvent 406 262 0 0 0 0 0
MouseMoveEvent 407 262 0 0 0 0 0
MouseMoveEvent 409 262 0 0 0 0 0
TimerEvent 409 262 0 0 0 0 0
MouseMoveEvent 411 261 0 0 0 0 0
MouseMoveEvent 412 261 0 0 0 0 0
MouseMoveEvent 413 261 0 0 0 0 0
TimerEvent 413 261 0 0 0 0 0
TimerEvent 413 261 0 0 0 0 0
TimerEvent 413 261 0 0 0 0 0
TimerEvent 413 261 0 0 0 0 0
TimerEvent 413 261 0 0 0 0 0
TimerEvent 413 261 0 0 0 0 0
TimerEvent 413 261 0 0 0 0 0
TimerEvent 413 261 0 0 0 0 0
MouseMoveEvent 414 261 0 0 0 0 0
MouseMoveEvent 415 261 0 0 0 0 0
TimerEvent 415 261 0 0 0 0 0
TimerEvent 415 261 0 0 0 0 0
TimerEvent 415 261 0 0 0 0 0
TimerEvent 415 261 0 0 0 0 0
TimerEvent 415 261 0 0 0 0 0
MouseMoveEvent 416 261 0 0 0 0 0
TimerEvent 416 261 0 0 0 0 0
MouseMoveEvent 417 261 0 0 0 0 0
TimerEvent 417 261 0 0 0 0 0
MouseMoveEvent 418 261 0 0 0 0 0
TimerEvent 418 261 0 0 0 0 0
MouseMoveEvent 419 261 0 0 0 0 0
MouseMoveEvent 420 261 0 0 0 0 0
TimerEvent 420 261 0 0 0 0 0
MouseMoveEvent 421 261 0 0 0 0 0
MouseMoveEvent 422 260 0 0 0 0 0
TimerEvent 422 260 0 0 0 0 0
MouseMoveEvent 423 260 0 0 0 0 0
MouseMoveEvent 424 260 0 0 0 0 0
MouseMoveEvent 426 259 0 0 0 0 0
TimerEvent 426 259 0 0 0 0 0
MouseMoveEvent 427 258 0 0 0 0 0
TimerEvent 427 258 0 0 0 0 0
TimerEvent 427 258 0 0 0 0 0
TimerEvent 427 258 0 0 0 0 0
MouseMoveEvent 428 258 0 0 0 0 0
TimerEvent 428 258 0 0 0 0 0
MouseMoveEvent 429 258 0 0 0 0 0
MouseMoveEvent 430 257 0 0 0 0 0
TimerEvent 430 257 0 0 0 0 0
MouseMoveEvent 431 257 0 0 0 0 0
MouseMoveEvent 432 257 0 0 0 0 0
MouseMoveEvent 433 257 0 0 0 0 0
TimerEvent 433 257 0 0 0 0 0
MouseMoveEvent 434 257 0 0 0 0 0
TimerEvent 434 257 0 0 0 0 0
MouseMoveEvent 435 257 0 0 0 0 0
TimerEvent 435 257 0 0 0 0 0
TimerEvent 435 257 0 0 0 0 0
TimerEvent 435 257 0 0 0 0 0
LeftButtonReleaseEvent 435 257 0 0 0 0 0
15 changes: 14 additions & 1 deletion vtkext/private/module/vtkF3DImguiActor.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,20 @@ void vtkF3DImguiActor::RenderSceneHierarchy(vtkOpenGLRenderWindow* renWin)
ImGuiWindowFlags_NoBringToFrontOnFocus | ImGuiWindowFlags_NoSavedSettings |
ImGuiWindowFlags_HorizontalScrollbar;

ImGui::Begin("Scene Hierarchy", nullptr, flags);
// Set up window with disabled left edge rescaling

ImVec2 gotMousePosition = ImGui::GetMousePos();

ImVec2 gotWindowPosition = ImVec2(0.0f, 0.0f);

if (gotMousePosition.x - 7 <= posX && ImGui::IsAnyItemActive() == false)
{
ImGui::Begin("Scene Hierarchy", nullptr, flags | ImGuiWindowFlags_NoResize);
}
else
{
ImGui::Begin("Scene Hierarchy", nullptr, flags);
}
Comment on lines +602 to +609
Copy link
Copy Markdown
Contributor

@snoyer snoyer Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (gotMousePosition.x - 7 <= posX && ImGui::IsAnyItemActive() == false)
{
ImGui::Begin("Scene Hierarchy", nullptr, flags | ImGuiWindowFlags_NoResize);
}
else
{
ImGui::Begin("Scene Hierarchy", nullptr, flags);
}
if (gotMousePosition.x - posX <= 7 && ImGui::IsAnyItemActive() == false)
{
flags |= ImGuiWindowFlags_NoResize;
}
ImGui::Begin("Scene Hierarchy", nullptr, flags);

I think it's simpler to modify flags instead of calling ImGui::Begin in each branch.

Also a - b <= threshold is more readable IMO. At first glance I'd even expect it to be abs(a - b) <= threshold, is that applicable here?


vtkF3DRenderer* ren = vtkF3DRenderer::SafeDownCast(renWin->GetRenderers()->GetFirstRenderer());
assert(ren != nullptr);
Expand Down
Loading