Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]: add base64url action #1052

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[WIP]: add base64url action #1052

wants to merge 3 commits into from

Conversation

EltonLobo07
Copy link
Contributor

@EltonLobo07 EltonLobo07 commented Feb 10, 2025 •
edited
Loading

closes #947

@vercel Vercel
Copy link

vercel bot commented Feb 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valibot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 8:23pm

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 10, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/valibot@1052

commit: e551b96

@EltonLobo07
Copy link
Contributor Author

@fabian-hiller Can you answer a couple of questions?

  1. Based on my research, the word 'base64url' is used as a single word (base64url or Base64url) instead of base64Url or Base64Url. To remain consistent, I have treated base64url as a single word. So the names of the types are Base64urlIssue, Base64urlAction and so on. Do you think we should use camel case instead (Base64UrlIssue, Base64UrlAction and so on)?
  2. Usually the doc comment has a Wikipedia link associated with the term. But base64url is not directly mentioned on Wikipedia. Out of the three links mentioned later, which one would you have used for the doc comment? #1, #2, or #3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for base64url regex validator
1 participant
@EltonLobo07