-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support of vitest benchmark #99
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for valibot canceled.
|
Thank you very much! The next few days I have to focus on my bachelor thesis. As soon as I find time, I'll get back to you. |
Do you have any idea how we can make the result comparable to the latest version of Valibot, so we can see if changes have a positive or negative impact on the performance? |
We could add the latest version of Valibot as a dev dependency and run the benchmark for both to have a comparison of the codebase to the latest Valibot version. |
That's great idea for local testing without pull request! But I should research if adding dev dependency can make a conflict with existing package name or add alias to dependency to avoid collision. |
Hi, @fabian-hiller, I added valibot dependency and now it's possible to compare current and latest perfomance in tests. Can you check it? |
Yes, I will try to check it in the next few days. |
b997a0f
to
6d0cde4
Compare
Sorry for not coming back to this, but other things had a higher priority. I am also not sure if we really need it, since the basic structure of the library is set and changes will most likely not have a major impact on performance. It is still useful, but other things have a higher priority for me. |
41ae798
to
4a7ee57
Compare
7a97dd0
to
b5f7f4d
Compare
f41426c
to
d713dfe
Compare
This separated pr is required to merge into main branch for testing github actions workflow in next coming pr #100. I just copied one of the tests from typescript-runtime-type-benchmark just for demo purposes.
Is
benchmarks
folder in ./library/src good place for storing benchmarks files?