Skip to content

Conversation

@fabiendostie
Copy link
Owner

@fabiendostie fabiendostie commented Apr 17, 2025

-w

…rea, and transitions

- Panels now always visible and sized (2/3 CSV, 1/3 results)
- Results panel always visible, never scrolls page
- Logo is white in dark mode using CSS filter
- Upload area compact when CSV loaded
- Validation results persist when toggling schema panel
- Smoother, much slower schema panel transition
- Icon sizes unified in headers
- Various minor UI/UX fixes
@fabiendostie fabiendostie force-pushed the feat/human-readable-schema-validation-ui branch from 87b2364 to 40aeb2b Compare April 17, 2025 11:45
@fabiendostie fabiendostie requested a review from Copilot April 17, 2025 11:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces enhancements to improve the schema validation UI and related developer tooling.

  • In csv-validator.worker.js, a try–catch block has been added for robust error handling and the payload property for the schema was renamed for clarity.
  • A new script (copy-templates.mjs) handles reliable copying of template assets from the package manager’s nested node_modules structure.
  • The next.config.mjs file has been updated with custom webpack rules to support worker files.
  • In code-editor.tsx, new props and effects were added to support line highlighting and auto-scroll, and a new API route (route.ts) creates markdown documentation from a JSON schema.

Reviewed Changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
workers/csv-validator.worker.js Adds try–catch for top-level error handling and renames payload schema.
scripts/copy-templates.mjs Introduces a robust template copying script using fs-extra.
next.config.mjs Adds webpack configuration for worker files and URL parsing adjustment.
components/code-editor.tsx Adds properties and effects for highlighting and scrolling in the editor.
app/api/generate-schema-doc/route.ts Adds an API endpoint for generating markdown documentation from schema.
Files not reviewed (2)
  • package.json: Language not supported
  • public/__schema_templates/schema.hbs: Language not supported
Comments suppressed due to low confidence (2)

workers/csv-validator.worker.js:121

  • [nitpick] Consider reviewing the naming convention between 'schema' and 'parsedSchema' to ensure consistency across the codebase.
const { csvData, schema: parsedSchema } = payload;

app/api/generate-schema-doc/route.ts:13

  • [nitpick] Consider renaming 'copyDirRecursive' to something like 'recursiveCopyDir' for improved clarity of its functionality.
async function copyDirRecursive(src: string, dest: string) {

Co-authored-by: Copilot <[email protected]>
Signed-off-by: fabiendostie <[email protected]>
@fabiendostie fabiendostie merged commit b5d2be7 into develop Apr 17, 2025
1 check passed
@fabiendostie fabiendostie deleted the feat/human-readable-schema-validation-ui branch April 17, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants