Performance improvement to the hide method#434
Open
vovayatsyuk wants to merge 4 commits into
Open
Conversation
vovayatsyuk
added a commit
to breezefront/module-breeze
that referenced
this pull request
Dec 20, 2024
Contributor
Author
|
I found a bug that is not caused by this PR, but the fix requires changing the same lines, so I pushed the fix here. I pushed failing test in the separate commit, so you can easily run it against unmodified code: |
vovayatsyuk
added a commit
to breezefront/module-breeze
that referenced
this pull request
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary style recalculation when using the
hidemethod. I faced a performance issue when started callinghideon thousands of elements.The improvement is made by getting rid of
computeStyleusage when callinghideand usingele.style.displayonly. Because it doesn't matter whatdisplayvalue was before hiding, ifdisplayis not inside the inline style attribute.Here is the jQuery implementation I used as a reference: https://github.com/jquery/jquery/blob/main/src/css/showHide.js#L44-L65
Here are the screenshots before PR (Total scripting 4x slowdown: 5 seconds):
Here are the screenshots after PR (Total scripting 4x slowdown: 1 second):