Fix shell parameter parsing #99
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make sense to parse more tokens if the current one fails. TODO: Word in input should match a complete word in title and not just a substring.
Collaborator
|
Thank you @pylonsoft ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #79.
It doesn't make sense to parse more tokens if the current one fails.
The old code matched two words in input "sen5x debug 1" for title "sen5x pm 1.0". It should had stopped at "debug" but went on to "1" and matched that in token "1.0".
TODO: Word in input should match a complete word in title and not just a substring. Not sure what the desired functionality is.