feat: align Cowboy bindings with cowboy 2.14 module structure#21
Merged
feat: align Cowboy bindings with cowboy 2.14 module structure#21
Conversation
Move route/hostRule helpers from Cowboy.fs to CowboyRouter.fs where they belong (router dispatch data structures). Add getEnv/setEnv bindings to Cowboy.fs. Remove narrow protoOpts/transportOpts helpers that don't map to real cowboy module functions. Update doc URLs to 2.14. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
routeandhostRulehelpers fromCowboy.fstoCowboyRouter.fsto match the Erlang module they belong to (cowboy_router)getEnv/setEnvbindings toCowboy.fs(maps tocowboy:get_env/2andcowboy:set_env/3)protoOpts/transportOptsconvenience helpers that don't correspond to any cowboy module function and were too narrow (port-only / dispatch-only)hostRuleaccept an explicit host parameter instead of hardcoding'_', matching the actual{HostMatch, PathList}dispatch formatTest plan
dotnet buildCowboyRouter.route,CowboyRouter.hostRule, andCowboyRouter.compileproduce correct Erlang termsCowboy.getEnvandCowboy.setEnvagainst a running listener🤖 Generated with Claude Code