fix: Support libraries using TargetFrameworks property

[roboz0r]

Copies the build directory to buildCrossTargeting when creating packages so the SDK will work as expected with libraries using TargetFrameworks dotnet/msbuild#1860

• Fixes SDK does not run on projects targeting multiple TFMs #11

[MangelMaxime]

Hello,

Thanks for the PR could you please add tests too to check that everything works as expected for TargetFrameworks too.

I don't think we need the full suit of test, the following should be enough I think:

• Fail if we don't have the the required tag
• Tags, files, etc. are added if all is configured correctly (can be done in a single test I think)

[roboz0r]

Creating a test project like the others in the repo will work but won't demonstrate the fix. Using explicit Import like the existing tests works fine without the changes I made.

The way I tested it manually was:

• Create the Fable.Package.SDK package locally with an incremented version number e.g. 1.4.0
• Create a test project library with <PackageReference Include="Fable.Package.SDK" Version="1.4.0">
• Add nuget.config for a local package reference

<configuration>
  <packageSources>
    <!-- The <clear/> line below removes the global NuGet package sources. -->
    <clear />
    <add key="nuget" value="https://api.nuget.org/v3/index.json" />
    <add key="local" value="C:\Users\Robert\GitHub\sdk-test\packages" />
  </packageSources>
  <packageSourceMapping>
    <!-- key value for <packageSource> should match key values from <packageSources> element -->
    <packageSource key="nuget">
      <package pattern="*" />
    </packageSource>
    <packageSource key="local">
      <package pattern="Fable.Package.SDK" />
    </packageSource>
  </packageSourceMapping>
</configuration>

• Run dotnet pack on sdk-test project to confirm errors without and success with required tags
• Inspect the produced package and confirm the .fs files were bundled

I'm not sure if there's a good way to automate this for a test?

[MangelMaxime]

Creating a test project like the others in the repo will work but won't demonstrate the fix. Using explicit Import like the existing tests works fine without the changes I made.

Even, by changing <TargetFramework>netstandard2.0</TargetFramework> to <TargetFrameworks>netstandard2.0</TargetFrameworks> ?

I'm not sure if there's a good way to automate this for a test?

We could automate all this setup, but this is probably more work for something which is not too worth. If the issue keep happening because we release regression then it could be worth considering in the future.

Thanks for the PR, I will review it a little later

[roboz0r]

Yes, I've published XParsec by using direct Import here and using <TargetFrameworks>net8.0;netstandard2.0</TargetFrameworks> which is confirmed working as expected.

https://github.com/roboz0r/XParsec/blob/fa8fcff6e37484fd16bee5105a9892faaeefbe01/src/XParsec/XParsec.fsproj#L41-L42

[roboz0r]

I've added some basic tests which should identify any regressions that would make the targets multi-tfm incompatible. I didn't go the whole way as I described in the manual testing.

[MangelMaxime]

Thanks for the PR, it has been released in 1.3.1

[roboz0r]

Looks like you went to the effort of the full test simulation. Nice work!

[MangelMaxime]

Looks like you went to the effort of the full test simulation. Nice work!

Yes, I needed to do that because otherwise the test was succeeding even without your fix.