Skip to content
This repository was archived by the owner on Mar 11, 2021. It is now read-only.

Conversation

@pmacik
Copy link
Contributor

@pmacik pmacik commented Apr 9, 2019

This PR adds the consumer side of the contract tests for the Tenant service consuming Auth service API endpoints.

PR CICO job: openshiftio/openshiftio-cico-jobs#997

The provider side (Auth service) of the contract tests is covered by fabric8-services/fabric8-auth#711

Story: https://jira.coreos.com/browse/ODC-249
Task: https://jira.coreos.com/browse/ODC-476

@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #767 into master will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   75.01%   75.56%   +0.54%     
==========================================
  Files          38       38              
  Lines        3146     3278     +132     
==========================================
+ Hits         2360     2477     +117     
- Misses        585      600      +15     
  Partials      201      201
Impacted Files Coverage Δ
configuration/configuration.go 70.61% <0%> (-0.48%) ⬇️
update/versions.go 100% <0%> (ø) ⬆️
openshift/types.go 93.75% <0%> (+1.25%) ⬆️
environment/service.go 97.81% <0%> (+6.14%) ⬆️
environment/type.go 60% <0%> (+6.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c48499...76d4dcf. Read the comment docs.

@pmacik pmacik changed the title [WIP] contract-tests: Add contract tests for consuming fabric8-auth service. contract-tests: Add contract tests for consuming fabric8-auth service. Apr 9, 2019
@pmacik pmacik requested a review from MatousJobanek April 10, 2019 08:59
Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late review.
This looks good, thanks a lot for doing these tests 👍

@MatousJobanek MatousJobanek merged commit 959c198 into fabric8-services:master May 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants