This repository was archived by the owner on Mar 11, 2021. It is now read-only.
Add consumer side of WIT+Auth contract tests. #2393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch? |
1 similar comment
Collaborator
|
Can one of the admins verify this patch? |
Collaborator
|
Can one of the admins verify this patch? |
pmacik
changed the title
pmacik
force-pushed
the
contract-tests-poc
branch
from
2465e9f to
d02c0ad
Compare
alien-ike
changed the title
kwk
suggested changes
Jan 21, 2019
kwk
suggested changes
Jan 21, 2019
pmacik
force-pushed
the
contract-tests-poc
branch
from
e497bd3 to
f9d4840
Compare
pmacik
changed the title
pmacik
force-pushed
the
contract-tests-poc
branch
2 times, most recently
from
4242601 to
f3e28d7
Compare
pmacik
changed the title
pmacik
force-pushed
the
contract-tests-poc
branch
from
f3e28d7 to
0383ca6
Compare
Co-Authored-By: pmacik <[email protected]>
Co-Authored-By: pmacik <[email protected]>
Co-Authored-By: pmacik <[email protected]>
Co-Authored-By: pmacik <[email protected]>
kwk
approved these changes
Jan 29, 2019
Collaborator
kwk
left a comment
kwk
left a comment
There was a problem hiding this comment.
LGTM Thanks for your patience
Collaborator
|
[test] |
Collaborator
|
[test] |
dipak-pawar
reviewed
Feb 14, 2019
Contributor
Author
|
[test] |
Contributor
Author
|
[test] |
Codecov Report
@@ Coverage Diff @@
## master #2393 +/- ##
==========================================
- Coverage 67.73% 67.67% -0.07%
==========================================
Files 183 183
Lines 18123 18123
==========================================
- Hits 12276 12265 -11
- Misses 4664 4675 +11
Partials 1183 1183
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds consumer side of the contract tests for the WIT service consuming Auth service API endpoints.
CICO job: openshiftio/openshiftio-cico-jobs#940
The provider side (Auth service) of the contract tests is covered by fabric8-services/fabric8-auth#711
WorkItem: https://openshift.io/openshiftio/Openshift_io/plan/detail/1329