initial clean-up of deployment API #2395
Conversation
corinnekrych
changed the title
corinnekrych
force-pushed
the
osio1315.removal.of.deployement.api
branch
from
c633a4e to
9c5c0cb
Compare
corinnekrych
changed the title
xcoulon
left a comment
xcoulon
left a comment
There was a problem hiding this comment.
this was a huge "chainsaw" operation, @corinnekrych!
Indeed! ✂️ 💇 |
| // now delete the OpenShift resources associated with this space on an | ||
| // OpenShift cluster, unless otherwise specified | ||
| if ctx.SkipCluster == nil || !*ctx.SkipCluster { | ||
| err = deleteOpenShiftResource(c.DeploymentsClient, config, ctx.Context, spaceID) |
There was a problem hiding this comment.
How are deployments deleted if not through the API?
There was a problem hiding this comment.
yeap, indeed another services will have to deal with deployment resources.
This is the purpose of this PR remove deployment out of wit.
In an event-driven world, an event sent for delete space would triggered a subscribed deployment service.
There was a problem hiding this comment.
The deleteOpenshiftResource method fails a lot of times and we already have an issue to fix it openshiftio/openshift.io#4657. Since @kwk will be implementing an improved version of space deletion (in future), I'm in favour of deleting this method.
|
@corinnekrych , could you please verify that on the UI side, this API is really not used ( experimental / non experimental views ) ? |
|
to be merged after fabric8-ui/fabric8-ui#3502 |
|
@sbose78 @jarifibrahim since UI PR is merged 🎉 could we have another review on this one and potentially merge it? |
jarifibrahim
left a comment
jarifibrahim
left a comment
There was a problem hiding this comment.
Thank you for cleaning up the code :)
| // now delete the OpenShift resources associated with this space on an | ||
| // OpenShift cluster, unless otherwise specified | ||
| if ctx.SkipCluster == nil || !*ctx.SkipCluster { | ||
| err = deleteOpenShiftResource(c.DeploymentsClient, config, ctx.Context, spaceID) |
There was a problem hiding this comment.
The deleteOpenshiftResource method fails a lot of times and we already have an issue to fix it openshiftio/openshift.io#4657. Since @kwk will be implementing an improved version of space deletion (in future), I'm in favour of deleting this method.
6 participants
fixes https://openshift.io/openshiftio/Openshift_io/plan/detail/1315