Call additionalConfig when building vertx http client with the stock VertxHttpClientFactory #7384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VertxHttpClientFactory
capistrant
requested review from
manusa,
rohanKanojia and
shawkins
as code owners
11 tasks
shawkins
approved these changes
Dec 17, 2025
Contributor
shawkins
left a comment
shawkins
left a comment
There was a problem hiding this comment.
Thank you @capistrant this looks good to me.
@manusa this should be ready to merge.
| }); | ||
| } | ||
|
|
||
| // Since the factory is not explicitly typed as VertxHttpClientFactory, we need to check the type before invoking |
Contributor
There was a problem hiding this comment.
It's perfectly fine to do this instanceOf check. Quarkus is using their own factory type with this builder.
Contributor
There was a problem hiding this comment.
An alternative to make this available to other factories is to introduce an interface for this specific additionalConfig method signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7252
Description
Align vert.x with the other supported Http clients in the area of supporting calling
additionalConfigfrom the associated Builder, allowing users of the client to do some customization of the base config for the client. Since the vert.x client does not strictly type the factory used by the builder like the other supported clients do, I added type check to only call additionalConfig when the factory in use is the baseVertxHttpClientFactory. This is not ideal, but since the underlying HttpClient.Factory interface does not haveadditionalConfigin the contract, I don't think there is much we can do that would not be a breaking change, without explicitly checking the factory type.I had proposed #7315 as an alternative non-breaking change to this issue, but since that did not get much traction, I wanted to see if there is more appetite for this. I think giving this flexibility to clients using vert.x would be very useful for folks wanting a bit more customization capability like they get with the other backing http clients.
Type of change
test, version modification, documentation, etc.)
Checklist