feat: metadata for graal VM config#7429
Open
ash-thakur-rh wants to merge 3 commits intofabric8io:mainfrom
Open
feat: metadata for graal VM config#7429ash-thakur-rh wants to merge 3 commits intofabric8io:mainfrom
ash-thakur-rh wants to merge 3 commits intofabric8io:mainfrom
Conversation
# Conflicts: # CHANGELOG.md
4c4f765 to
932f105
Compare
manusa
requested changes
Feb 17, 2026
Member
manusa
left a comment
There was a problem hiding this comment.
Looking good, thx.
I don't think you need to do the convoluted call from one script to another, just extract the required method so that it can be called from either.
Then, in the wrapper, you can actually use JBang's //SOURCE annotation to create the dependency and import for the other class.
You can find an example of this at:
https://github.com/marcnuri-demo/blog-tutorials/blob/11ac44f167581f07e11d49d7e0192dfcbee71915/java-virtual-threads-project-loom-complete-guide/Test.java#L4-L9
Also, I'm not sure if we should add a Makefile target for this, the Makefile could easily check too if JBang is available and spit an error in case it isn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5084
Type of change
test, version modification, documentation, etc.)
Checklist