Skip to content

feat: metadata for graal VM config#7429

Open
ash-thakur-rh wants to merge 3 commits intofabric8io:mainfrom
ash-thakur-rh:graal/feat-metadata-creation
Open

feat: metadata for graal VM config#7429
ash-thakur-rh wants to merge 3 commits intofabric8io:mainfrom
ash-thakur-rh:graal/feat-metadata-creation

Conversation

@ash-thakur-rh
Copy link
Member

Description

Fixes #5084

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@ash-thakur-rh ash-thakur-rh changed the title feat: create metadata generator plugin feat: metadata for graal VM config Feb 9, 2026
@ash-thakur-rh ash-thakur-rh marked this pull request as ready for review February 16, 2026 09:02
@ash-thakur-rh ash-thakur-rh force-pushed the graal/feat-metadata-creation branch from 4c4f765 to 932f105 Compare February 16, 2026 09:33
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thx.
I don't think you need to do the convoluted call from one script to another, just extract the required method so that it can be called from either.
Then, in the wrapper, you can actually use JBang's //SOURCE annotation to create the dependency and import for the other class.
You can find an example of this at:
https://github.com/marcnuri-demo/blog-tutorials/blob/11ac44f167581f07e11d49d7e0192dfcbee71915/java-virtual-threads-project-loom-complete-guide/Test.java#L4-L9

Also, I'm not sure if we should add a Makefile target for this, the Makefile could easily check too if JBang is available and spit an error in case it isn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add graalvm-reachability-metadata for kubernetes client

2 participants