Skip to content

Let repo init use the target server default environment#586

Merged
brynary merged 1 commit into
mainfrom
fix/repo-init-default-environment
Jul 22, 2026
Merged

Let repo init use the target server default environment#586
brynary merged 1 commit into
mainfrom
fix/repo-init-default-environment

Conversation

@brynary

@brynary brynary commented Jul 22, 2026

Copy link
Copy Markdown
Member

Summary

  • stop pinning the generated hello workflow to the local sandbox provider
  • let environment resolution fall through to the target server default
  • update the repo init integration snapshot for the minimal workflow config

This prevents a freshly initialized project from failing when the selected remote server disables the local provider and supplies a remote default environment.

Testing

  • cargo nextest run -p fabro-cli --test it repo_init
  • cargo +nightly-2026-04-14 fmt --check --all
  • cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings
  • cargo insta pending-snapshots
  • git diff --check

Copilot AI review requested due to automatic review settings July 22, 2026 18:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts fabro repo init so the generated “hello” workflow does not force the local environment, allowing environment selection to fall through to the target server’s configured default (avoiding failures when local is disabled on a remote server).

Changes:

  • Stop generating [run.environment] / [environments.local] blocks in the default hello workflow’s workflow.toml.
  • Update the repo-init integration test snapshot to match the minimal workflow config.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/crates/fabro-cli/tests/it/cmd/repo_init.rs Updates the workflow.toml snapshot to remove the pinned local environment config.
lib/crates/fabro-cli/src/commands/repo/init.rs Generates a minimal workflow.toml that leaves environment resolution to defaults (e.g., server default).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@brynary
brynary merged commit 25f1f64 into main Jul 22, 2026
14 checks passed
@brynary
brynary deleted the fix/repo-init-default-environment branch July 22, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants