Let repo init use the target server default environment#586
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts fabro repo init so the generated “hello” workflow does not force the local environment, allowing environment selection to fall through to the target server’s configured default (avoiding failures when local is disabled on a remote server).
Changes:
- Stop generating
[run.environment]/[environments.local]blocks in the defaulthelloworkflow’sworkflow.toml. - Update the repo-init integration test snapshot to match the minimal workflow config.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/crates/fabro-cli/tests/it/cmd/repo_init.rs | Updates the workflow.toml snapshot to remove the pinned local environment config. |
| lib/crates/fabro-cli/src/commands/repo/init.rs | Generates a minimal workflow.toml that leaves environment resolution to defaults (e.g., server default). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This prevents a freshly initialized project from failing when the selected remote server disables the local provider and supplies a remote default environment.
Testing