Set priority of markdown_messages #3113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66368295 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3113 +/- ##
=======================================
Coverage 95.43% 95.43%
=======================================
Files 503 503
Lines 50316 50342 +26
=======================================
+ Hits 48018 48044 +26
Misses 2298 2298 ☔ View full report in Codecov by Sentry. |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Nov 25, 2024
Summary: This diff: * Introduces `OutputPriority`, which categorizes the urgency and therefore placement of each message, to be expanded to other output types. * Introduces `MessageOutput`, which has fields `text` and `priority`. * Changes value type of `Scheduler.markdown_messages` dict from `str` to `MessageOutput`, so that all markdown_messages must have a priority associated with them. Differential Revision: D66368295
bernardbeckerman
force-pushed
the
export-D66368295
branch
from
73e6bc2 to
3fdcbe7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66368295 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Nov 25, 2024
Summary: This diff: * Introduces `OutputPriority`, which categorizes the urgency and therefore placement of each message, to be expanded to other output types. * Introduces `MessageOutput`, which has fields `text` and `priority`. * Changes value type of `Scheduler.markdown_messages` dict from `str` to `MessageOutput`, so that all markdown_messages must have a priority associated with them. Differential Revision: D66368295
bernardbeckerman
force-pushed
the
export-D66368295
branch
from
3fdcbe7 to
44d2d13
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66368295 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Nov 25, 2024
Summary: This diff: * Introduces `OutputPriority`, which categorizes the urgency and therefore placement of each message, to be expanded to other output types. * Introduces `MessageOutput`, which has fields `text` and `priority`. * Changes value type of `Scheduler.markdown_messages` dict from `str` to `MessageOutput`, so that all markdown_messages must have a priority associated with them. Differential Revision: D66368295
bernardbeckerman
force-pushed
the
export-D66368295
branch
from
44d2d13 to
661d2da
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66368295 |
bernardbeckerman
force-pushed
the
export-D66368295
branch
from
661d2da to
a93204b
Compare
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Nov 25, 2024
Summary: This diff: * Introduces `OutputPriority`, which categorizes the urgency and therefore placement of each message, to be expanded to other output types. * Introduces `MessageOutput`, which has fields `text` and `priority`. * Changes value type of `Scheduler.markdown_messages` dict from `str` to `MessageOutput`, so that all markdown_messages must have a priority associated with them. Differential Revision: D66368295
|
This pull request was exported from Phabricator. Differential Revision: D66368295 |
Summary: This diff: * Introduces `OutputPriority`, which categorizes the urgency and therefore placement of each message, to be expanded to other output types. * Introduces `MessageOutput`, which has fields `text` and `priority`. * Changes value type of `Scheduler.markdown_messages` dict from `str` to `MessageOutput`, so that all markdown_messages must have a priority associated with them. Reviewed By: Balandat Differential Revision: D66368295
bernardbeckerman
force-pushed
the
export-D66368295
branch
from
a93204b to
0f937a6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66368295 |
|
This pull request has been merged in 53420b6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff:
OutputPriority, which categorizes the urgency and therefore placement of each message, to be expanded to other output types.MessageOutput, which has fieldstextandpriority.Scheduler.markdown_messagesdict fromstrtoMessageOutput, so that all markdown_messages must have a priority associated with them.Differential Revision: D66368295