Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gen fallback model spec for GenerationNode #3209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ItsMrLin
Copy link
Contributor

Summary: Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen()

Differential Revision: D67232696

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 22, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67232696

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (6607582) to head (57a1cc0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3209   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files         513      513           
  Lines       51636    51651   +15     
=======================================
+ Hits        49505    49520   +15     
  Misses       2131     2131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request Dec 26, 2024
Summary:

Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen()

Differential Revision: D67232696
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67232696

ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request Dec 26, 2024
Summary:

Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen()

Differential Revision: D67232696
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67232696

Summary:

Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen()

Differential Revision: D67232696
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67232696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants