Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use most recent trial in TransformToNewSQ by default #3225

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sdaulton
Copy link
Contributor

@sdaulton sdaulton commented Jan 6, 2025

Summary: see title. This ensures that status_quo_data_by_trial contains the target trial index by default.

Differential Revision: D67875128

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 6, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67875128

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.88%. Comparing base (5be6f17) to head (3d5d17f).

Files with missing lines Patch % Lines
ax/modelbridge/transforms/transform_to_new_sq.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3225      +/-   ##
==========================================
- Coverage   95.88%   95.88%   -0.01%     
==========================================
  Files         513      513              
  Lines       51673    51679       +6     
==========================================
+ Hits        49545    49550       +5     
- Misses       2128     2129       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sdaulton added a commit to sdaulton/Ax-1 that referenced this pull request Jan 16, 2025
…wSQ (facebook#3225)

Summary:

see title. This ensures that status_quo_data_by_trial contains the target trial index by default.

Differential Revision: D67875128
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67875128

…wSQ (facebook#3225)

Summary:

see title. This ensures that status_quo_data_by_trial contains the target trial index by default.

Differential Revision: D67875128
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67875128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants