Cleanup in test_botorch_moo_defaults.BotorchMOODefaultsTest #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…faults.FrontierEvaluatorTest (facebook#3241) Summary: * Fit a model in which fitting had been mocked out before * Move some logic out of the `setUp` so that we don't fit a model in tests where it isn't needed * In `test_pareto_frontier_raise_error_when_missing_data`, use an unfit model Reviewed By: saitcakmak Differential Revision: D68214262
Summary: Context: I was aiming to remove unnecessary mocks here, but there actually weren't any; these mocks are being used to test that arguments are being passed through correctly. Changes: * Added some comments * Stopped instantiating an unneeded model (it was used only for its `model._model` attribute, which is None) * Pulled out repetitive `posterior` * Reduced the scope of a context manager by unindenting Differential Revision: D68233296
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68233296 |
|
This pull request has been merged in 81fba5c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context: I was aiming to remove unnecessary mocks here, but there actually weren't any; these mocks are being used to test that arguments are being passed through correctly.
Changes:
model._modelattribute, which is None)posteriorDifferential Revision: D68233296