Fix trial index returned by get_best_parameters_from_model_predictions_with_trial_index #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68834769 |
…s_with_trial_index (facebook#3284) Summary: This method has long been returning the index of the GR that was used to extract the best point, rather than returning the index of the trial that generated the best point. I came across it while looking into something else and figured I'd fix it while at it. This method & other existing best point utilities will likely be replaced in the near future, but it doesn't hurt to it work correctly in the mean time. Fixes facebook#1629 Reviewed By: esantorella Differential Revision: D68834769
saitcakmak
force-pushed
the
export-D68834769
branch
from
704f874 to
876e3c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68834769 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Jan 29, 2025
…s_with_trial_index (facebook#3284) Summary: This method has long been returning the index of the GR that was used to extract the best point, rather than returning the index of the trial that generated the best point. I came across it while looking into something else and figured I'd fix it while at it. This method & other existing best point utilities will likely be replaced in the near future, but it doesn't hurt to it work correctly in the mean time. Fixes facebook#1629 Reviewed By: esantorella Differential Revision: D68834769
|
This pull request has been merged in 9be04d6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This method has long been returning the index of the GR that was used to extract the best point, rather than returning the index of the trial that generated the best point. I came across it while looking into something else and figured I'd fix it while at it. This method & other existing best point utilities will likely be replaced in the near future, but it doesn't hurt to it work correctly in the mean time.
Fixes #1629
Differential Revision: D68834769