Allow delete_gs() to delete multiple with kwarg #3292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D68905693 |
facebook-github-bot
added
CLA Signed
Summary: Sometimes we get in a weird state with multiple GSs on an experiment and that was blocking deletion and loading Reviewed By: andycylmeta Differential Revision: D68905693
danielcohenlive
force-pushed
the
export-D68905693
branch
from
fa499d3 to
91b5671
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68905693 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3292 +/- ##
==========================================
+ Coverage 96.01% 96.04% +0.02%
==========================================
Files 518 518
Lines 52132 52162 +30
==========================================
+ Hits 50057 50098 +41
+ Misses 2075 2064 -11 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 9028fcf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Sometimes we get in a weird state with multiple GSs on an experiment and that was blocking deletion and loading
Reviewed By: andycylmeta
Differential Revision: D68905693