Reap rarely used/unused methods and properties #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69313269 |
Summary: There were very few instances of usage of the methods this removes, so this diff changes the callsites and reaps the methods. Reviewed By: saitcakmak Differential Revision: D69313269
lena-kashtelyan
force-pushed
the
export-D69313269
branch
from
e3f9161 to
5c0d5f6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69313269 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3333 +/- ##
==========================================
- Coverage 95.70% 95.70% -0.01%
==========================================
Files 532 532
Lines 52450 52438 -12
==========================================
- Hits 50196 50184 -12
Misses 2254 2254 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There were very few instances of usage of the methods this removes, so this diff changes the callsites and reaps the methods.
Differential Revision: D69313269