Deprecate GenerationStrategyInterface #3338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As titled - part of the January 2025 Better Engineering Sprint The high level goal is to eventually migrate `RemoteGS` → `RemoteGenNode`, but after some discussions, we have decided to take the following actions: 1. Deprecate RemoteGS (there are no use cases for it as of today) 2. Deprecate GenerationStrategyInterface 3. Implement RemoteGenNode when the use case surfaces This diff is for step 2, and follow up diffs will be made for step 3 when needed Differential Revision: D69253188
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69253188 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3338 +/- ##
========================================
Coverage 95.70% 95.70%
========================================
Files 533 531 -2
Lines 52537 52427 -110
========================================
- Hits 50278 50173 -105
+ Misses 2259 2254 -5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As titled - part of the January 2025 Better Engineering Sprint
The high level goal is to eventually migrate
RemoteGS→RemoteGenNode, but after some discussions, we have decided to take the following actions:This diff is for step 2, and follow up diffs will be made for step 3 when needed
Differential Revision: D69253188