Clean up Axolotl-for-PTS units + some issues that surfaced during the cleanup #3377
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69616303 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 14, 2025
… cleanup (facebook#3377) Summary: As titled, a bit of cleanup and ensuring that we choose the correct GS + experiment types Reviewed By: mgarrard Differential Revision: D69616303
lena-kashtelyan
force-pushed
the
export-D69616303
branch
from
7c6c013 to
3126a27
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69616303 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 14, 2025
…ok#3377) Summary: As titled, a bit of cleanup and ensuring that we choose the correct GS + experiment types Reviewed By: mgarrard Differential Revision: D69616303
lena-kashtelyan
force-pushed
the
export-D69616303
branch
from
3126a27 to
f069409
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69616303 |
…ok#3377) Summary: As titled, a bit of cleanup and ensuring that we choose the correct GS + experiment types Reviewed By: mgarrard Differential Revision: D69616303
lena-kashtelyan
force-pushed
the
export-D69616303
branch
from
f069409 to
f92efd6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69616303 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3377 +/- ##
=======================================
Coverage 95.72% 95.72%
=======================================
Files 538 538
Lines 52684 52684
=======================================
Hits 50430 50430
Misses 2254 2254 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled, a bit of cleanup and ensuring that we choose the correct GS + experiment types
Differential Revision: D69616303