Move input constructor logic to GenNode
#3378
Open
+636
−535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69619733 |
Summary:
This diff removes _gen_multiple and replaces it with calls to gen_for_multiple_with_multiple.
We plan to replace gen() with gen_for_multiple_with_multiple() with the Ax1.0 release so will keep both around for now.
Internal
-
Tldr:
{F1973912988}
See diff 1/n in the stack for context
Reviewed By: saitcakmak
Differential Revision: D67319697
Summary: Pull Request resolved: facebook#3378 Differential Revision: D69619733
lena-kashtelyan
force-pushed
the
export-D69619733
branch
from
9bf2ef7 to
bcf95d9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69619733 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D69619733