Deprecate FixedParameter in favor of single-element ChoiceParameter #3397
+66
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68241762 |
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Feb 20, 2025
…acebook#3397) Summary: As titled. Deprecating `FixedParameter` Doing a "soft" deprecation (i.e. instantiate`ChoiceParameter` if `FixedParameterConfig` is given) becuase there are partner integration code that relies on `FixedParameterConfig` (e.g. https://fburl.com/code/7nxmqhim) Differential Revision: D68241762
sunnyshen321
force-pushed
the
export-D68241762
branch
from
ab5928f to
e7cb051
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68241762 |
…acebook#3397) Summary: Deprecating `FixedParameter` -- if `FixedParameterConfig` is used, we will create a single-element `ChoiceParameter` instead Doing a "soft" deprecation (i.e. instantiate`ChoiceParameter` if `FixedParameterConfig` is given instead of erroring out) because many partner integration code relies on `FixedParameterConfig` (e.g. https://fburl.com/code/7nxmqhim) Differential Revision: D68241762
sunnyshen321
force-pushed
the
export-D68241762
branch
from
e7cb051 to
5bee7dc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68241762 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As titled. Deprecating
FixedParameterDoing a "soft" deprecation (i.e. instantiate
ChoiceParameterifFixedParameterConfigis given) becuase there are partner integration code that relies onFixedParameterConfig(e.g. https://fburl.com/code/7nxmqhim)Differential Revision: D68241762