Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow suppressing parameter validation errors in ax_client.attach_trial() (#3269) #3402

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Allow suppressing parameter validation errors in ax_client.attach_trial() (#3269) #3402

wants to merge 7 commits into from

Conversation

josephinecowley
Copy link

@josephinecowley josephinecowley commented Feb 21, 2025 •
edited
Loading

Addresses #3269

  • Added function parameter raise_parameter_error to ax_client.attach_trial() and passed raise_parameter_error through to raise_error in search_space.validate_membership
    • Default value is True and should not impact existing usage
  • Included docstrings for new parameters
  • Implemented corresponding unit tests for invalid parameters (with and without supressing errors)

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephinecowley @facebook-github-bot