Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black "x"s at sampled coordinates in contour plot #3406

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mpolson64
Copy link
Contributor

Summary: As titled.

Differential Revision: D69989849

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 21, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69989849

Summary:

As titled. Added comments as well to show whats going on.

Differential Revision: D69987525
Summary:

As titled. These are moderately useful here, but I really want to add them to the contour plot and I want the slice plot to match since theyre often displayed together.

Differential Revision: D69988707
Summary:

As titled.

Differential Revision: D69989849
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69989849

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (63a1eaf) to head (d9826bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3406   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files         539      539           
  Lines       52794    52813   +19     
=======================================
+ Hits        50677    50696   +19     
  Misses       2117     2117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants