Only load completed map metrics by default #3409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70012386 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Feb 21, 2025
Summary: This commit ensures that the `Adapter`only loads completed map metrics by default. This makes sure that any method (not-necessarily map-data aware) can be applied by default. Reviewed By: dme65 Differential Revision: D70012386
SebastianAment
force-pushed
the
export-D70012386
branch
from
f341c17 to
7e25077
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70012386 |
SebastianAment
force-pushed
the
export-D70012386
branch
from
7e25077 to
810e487
Compare
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Feb 21, 2025
Summary: This commit ensures that the `Adapter`only loads completed map metrics by default. This makes sure that any method (not-necessarily map-data aware) can be applied by default. Reviewed By: dme65 Differential Revision: D70012386
|
This pull request was exported from Phabricator. Differential Revision: D70012386 |
Summary: This commit ensures that the `Adapter`only loads completed map metrics by default. This makes sure that any method (not-necessarily map-data aware) can be applied by default. Reviewed By: dme65, saitcakmak Differential Revision: D70012386
SebastianAment
force-pushed
the
export-D70012386
branch
from
810e487 to
13b7ed0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70012386 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3409 +/- ##
==========================================
- Coverage 95.99% 95.98% -0.01%
==========================================
Files 539 539
Lines 52794 52797 +3
==========================================
+ Hits 50677 50678 +1
- Misses 2117 2119 +2 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 7c2788f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This commit ensures that the
Adapteronly loads completed map metrics by default. This makes sure that any method (not-necessarily map-data aware) can be applied by default.Differential Revision: D70012386