Skip to content

Deprecate Trial.runner#4460

Closed
eonofrey wants to merge 1 commit into
facebook:mainfrom
eonofrey:export-D83001393
Closed

Deprecate Trial.runner#4460
eonofrey wants to merge 1 commit into
facebook:mainfrom
eonofrey:export-D83001393

Conversation

@eonofrey

Copy link
Copy Markdown
Contributor

Summary:
Upstream functionality from MultiTypeExperiment._runner_by_trial_type

Full details in: T222906773 and doc, but a summary is:

{F1982739301}

Differential Revision: D83001393

@meta-codesync

meta-codesync Bot commented Oct 20, 2025

Copy link
Copy Markdown

@eonofrey has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83001393.

@meta-cla meta-cla Bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 20, 2025
@codecov-commenter

codecov-commenter commented Oct 21, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.05263% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.52%. Comparing base (6ada350) to head (ce8aef8).

Files with missing lines Patch % Lines
ax/core/base_trial.py 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4460      +/-   ##
==========================================
- Coverage   96.52%   96.52%   -0.01%     
==========================================
  Files         563      563              
  Lines       58836    58834       -2     
==========================================
- Hits        56792    56788       -4     
- Misses       2044     2046       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

eonofrey added a commit to eonofrey/Ax that referenced this pull request Nov 13, 2025
Summary:

Upstream functionality from MultiTypeExperiment._runner_by_trial_type

Full details in: T222906773 and [doc](https://docs.google.com/document/d/1u0J0VA2VzMkJO4n-J-8ngR0PNdd4CgCmePp8HUFRuTA/edit?tab=t.z51rdls4788k), but a summary is: 

 {F1982739301}

Reviewed By: mpolson64

Differential Revision: D83001393
eonofrey added a commit to eonofrey/Ax that referenced this pull request Dec 10, 2025
Summary:

Upstream functionality from MultiTypeExperiment._runner_by_trial_type

Full details in: T222906773 and [doc](https://docs.google.com/document/d/1u0J0VA2VzMkJO4n-J-8ngR0PNdd4CgCmePp8HUFRuTA/edit?tab=t.z51rdls4788k), but a summary is: 

 {F1982739301}

Reviewed By: mpolson64

Differential Revision: D83001393
eonofrey added a commit to eonofrey/Ax that referenced this pull request Dec 11, 2025
Summary:

Upstream functionality from MultiTypeExperiment._runner_by_trial_type

Full details in: T222906773 and [doc](https://docs.google.com/document/d/1u0J0VA2VzMkJO4n-J-8ngR0PNdd4CgCmePp8HUFRuTA/edit?tab=t.z51rdls4788k), but a summary is: 

 {F1982739301}

Reviewed By: mpolson64

Differential Revision: D83001393
Summary:

Upstream functionality from MultiTypeExperiment._runner_by_trial_type

Full details in: T222906773 and [doc](https://docs.google.com/document/d/1u0J0VA2VzMkJO4n-J-8ngR0PNdd4CgCmePp8HUFRuTA/edit?tab=t.z51rdls4788k), but a summary is: 

 {F1982739301}

Reviewed By: mpolson64

Differential Revision: D83001393
@meta-codesync

meta-codesync Bot commented Dec 15, 2025

Copy link
Copy Markdown

This pull request has been merged in 1f75852.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants