Enforce smoothing in [0, 1) in `TensorBoardMetric#4661
Closed
SebastianAment wants to merge 1 commit into
Closed
Conversation
Summary: Checks the `smoothing` parameter in the constructor. Differential Revision: D89211791
|
@SebastianAment has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89211791. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4661 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 567 567
Lines 59104 59114 +10
=======================================
+ Hits 57054 57065 +11
+ Misses 2050 2049 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 92e8311. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Checks the
smoothingparameter in the constructor.Differential Revision: D89211791