Store ExperimentStatus on Experiment class#4738
Closed
CristianLara wants to merge 2 commits into
Closed
Conversation
|
@CristianLara has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90089265. |
meta-cla
Bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4738 +/- ##
=======================================
Coverage 96.76% 96.76%
=======================================
Files 591 593 +2
Lines 61950 62039 +89
=======================================
+ Hits 59943 60033 +90
+ Misses 2007 2006 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CristianLara
added a commit
to CristianLara/Ax
that referenced
this pull request
Jan 7, 2026
Summary: # AOSC note Land xdb schema changes first D88096914 # Summary Store ExperimentStatus on Experiment class as `status` and introduce setters/getters, update SQA classes+encoder/decoder, and add tests. I've gone ahead and also defined methods in `storage/sqa_store/` to enable efficiently updating the property. Not currently used but will be used later in the stack by the orchestrator to set this status. Differential Revision: D90089265 Privacy Context Container: L1307644
CristianLara
force-pushed
the
export-D90089265
branch
from
3b06e1c to
3d20881
Compare
CristianLara
force-pushed
the
export-D90089265
branch
from
3d20881 to
71209a1
Compare
CristianLara
added a commit
to CristianLara/Ax
that referenced
this pull request
Feb 5, 2026
Summary: Pull Request resolved: facebook#4738 # AOSC note Land xdb schema changes first D88096914 # Summary Store ExperimentStatus on Experiment class as `status` and introduce setters/getters, update SQA classes+encoder/decoder, and add tests. Differential Revision: D90089265
CristianLara
pushed a commit
to CristianLara/Ax
that referenced
this pull request
Feb 6, 2026
Summary: Pull Request resolved: facebook#4738 # AOSC note Land xdb schema changes first D88096914 # Summary Store ExperimentStatus on Experiment class as `status` and introduce setters/getters, update SQA classes+encoder/decoder, and add tests. Differential Revision: D90089265
CristianLara
added a commit
to CristianLara/Ax
that referenced
this pull request
Feb 9, 2026
Summary: # AOSC note Land xdb schema changes first D88096914 # Summary Store ExperimentStatus on Experiment class as `status` and introduce setters/getters, update SQA classes+encoder/decoder, and add tests. Reviewed By: mgarrard Differential Revision: D90089265
CristianLara
force-pushed
the
export-D90089265
branch
from
71209a1 to
18b2e39
Compare
CristianLara
pushed a commit
to CristianLara/Ax
that referenced
this pull request
Feb 10, 2026
Summary: Pull Request resolved: facebook#4738 # AOSC note Land xdb schema changes first D88096914 # Summary Store ExperimentStatus on Experiment class as `status` and introduce setters/getters, update SQA classes+encoder/decoder, and add tests. Differential Revision: D90089265
Summary: # Summary Add `ExperimentStatus` enum with phases: DRAFT, INITIALIZATION, OPTIMIZATION, COMPLETED. **Backward compatibility:** The status field defaults to `None` for existing experiments, maintaining full backward compatibility. New experiments can optionally set status as needed. Reviewed By: mgarrard Differential Revision: D86801911
Summary: # AOSC note Land xdb schema changes first D88096914 # Summary Store ExperimentStatus on Experiment class as `status` and introduce setters/getters, update SQA classes+encoder/decoder, and add tests. Reviewed By: mgarrard Differential Revision: D90089265
CristianLara
force-pushed
the
export-D90089265
branch
from
18b2e39 to
7ff7bb6
Compare
|
This pull request has been merged in 98b0e66. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
AOSC note
Land xdb schema changes first D88096914
Summary
Store ExperimentStatus on Experiment class as
statusand introduce setters/getters, update SQA classes+encoder/decoder, and add tests.I've gone ahead and also defined methods in
storage/sqa_store/to enable efficiently updating the property. Not currently used but will be used later in the stack by the orchestrator to set this status.Differential Revision:
D90089265
Privacy Context Container: L1307644